You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "FavroiteGamers (via GitHub)" <gi...@apache.org> on 2026/03/11 05:04:21 UTC
[PR] Fixed #1413 [airflow-site]
FavroiteGamers opened a new pull request, #1443:
URL: https://github.com/apache/airflow-site/pull/1443
Updated Docsy to newest version, along with Hugo, and added mandatory dark mode flag to prevent errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Docsy theme [airflow-site]
Posted by "FavroiteGamers (via GitHub)" <gi...@apache.org>.
FavroiteGamers commented on PR #1443:
URL: https://github.com/apache/airflow-site/pull/1443#issuecomment-4043825611
I would suggest reverting it for the time being. I'll get the follow up tomorrow though! Apologizes for the fix not working!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Docsy theme [airflow-site]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1443:
URL: https://github.com/apache/airflow-site/pull/1443#issuecomment-4043238200
Shall we revert it ? or are you going to fix it quickly @FavroiteGamers ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Docsy theme [airflow-site]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1443:
URL: https://github.com/apache/airflow-site/pull/1443#issuecomment-4045292905
We are back with old template now. Take your time @FavroiteGamers and thanks for the work so far !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Docsy theme [airflow-site]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1443:
URL: https://github.com/apache/airflow-site/pull/1443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Docsy theme [airflow-site]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #1443:
URL: https://github.com/apache/airflow-site/pull/1443#issuecomment-4042543791
Thanks for working on this! The Hugo and Docsy version bumps are welcome, but I think the migration from Docsy v0.12.0 → v0.14.3 is incomplete and introduces a few issues that should be addressed in a follow-up.
### `sidebar-tree.html` — band-aid instead of proper fix
The new Docsy `sidebar.html` now always passes a dict (`{context, cacheSidebar, sidebarRoot, sidebarRootID}`) instead of the page directly. The change here:
```go
{{ $context := cond (isset . "context") .context . }}
```
has two problems:
1. **The `cond` backward-compat guard is dead code.** Since this same PR upgrades Docsy, `sidebar.html` always passes a dict — `isset . "context"` is always true. The fallback to `.` never triggers. This should just be `{{ $context := .context }}`.
2. **The custom override silently drops new arguments.** `cacheSidebar`, `sidebarRoot`, and `sidebarRootID` are all ignored. The new `sidebar.html` injects a `<script>` and adds `d-none` to `#td-sidebar-menu` expecting `sidebar-tree.html` to cooperate with cache-aware active-state rendering — this override doesn't.
More broadly, this custom partial is based on the old Docsy v0.12.0 structure and is now severely out of sync with the upstream 186-line template (missing foldable nav, search, sidebar root support, configurable truncation, etc.). Worth evaluating whether this override is still needed or if the upstream template can be used directly.
### `$enable-dark-mode: true !default;` — incorrect fix
```scss
$enable-dark-mode: true !default;
@import "td/code-dark";
```
- **`!default` is meaningless** — nothing defines this variable before this line, so `!default` has no effect.
- **The comment is misleading** — it says "we don't import bootstrap in Docsy's main.scss" but Bootstrap IS imported in Docsy's `td/_main.scss` (line 10). The actual issue is that `main-custom.scss` is a separate SCSS entry point that bypasses Docsy's pipeline.
- **`true` generates unnecessary CSS** — it outputs `[data-bs-theme='light']` and `[data-bs-theme='dark']` selectors. If the site doesn't have a functioning dark mode toggle, this is dead CSS.
The root issue is that `td/_code-dark.scss` in Docsy v0.14.x now expects Bootstrap variables to be in scope (it's wrapped in `@if $enable-dark-mode`). Importing it directly from `main-custom.scss` breaks that contract. The proper fix is to either route through Docsy's SCSS pipeline or import Bootstrap's variables first.
### General
Jumping 3 minor versions (v0.12.0 → v0.14.3) is a significant change. Docsy v0.13.0 and v0.14.0 both had breaking changes to SCSS structure, sidebar partials, and the dark mode system. This PR patches two compilation errors but doesn't fully address the migration. Would be good to audit the [Docsy changelog](https://www.docsy.dev/blog/) for other breaking changes and open a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Docsy theme [airflow-site]
Posted by "FavroiteGamers (via GitHub)" <gi...@apache.org>.
FavroiteGamers commented on PR #1443:
URL: https://github.com/apache/airflow-site/pull/1443#issuecomment-4043497597
@potiuk I can fix it within the next 3 hours. If you want to revert it, that's ok as well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Docsy theme [airflow-site]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1443:
URL: https://github.com/apache/airflow-site/pull/1443#issuecomment-4037682765
Can you post some screenshots ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Docsy theme [airflow-site]
Posted by "FavroiteGamers (via GitHub)" <gi...@apache.org>.
FavroiteGamers commented on PR #1443:
URL: https://github.com/apache/airflow-site/pull/1443#issuecomment-4047250817
Of course! Thanks so much for your understanding and help with all of this! It's really fun getting to work on a project like this! I'll have this done most likely before end of day today! @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Docsy theme [airflow-site]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1443:
URL: https://github.com/apache/airflow-site/pull/1443#issuecomment-4038737899
Ok. Run it locally - looks good :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Docsy theme [airflow-site]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1443:
URL: https://github.com/apache/airflow-site/pull/1443#issuecomment-4045069496
OK :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org