You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2017/08/22 22:09:53 UTC

Review Request 61824: [ATLAS-2078]: Updating types using v1 API doesn't route to createUpdateTypesDef in v2 API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61824/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2078
    https://issues.apache.org/jira/browse/ATLAS-2078


Repository: atlas


Description
-------

When updating types using v1 API, if type doesn't exist we create missing types. Currently this API maps to v2 API's update method and doesn't create missing types.


Diffs
-----

  intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java e1c5a7f5 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 7a0bbca1 
  webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java f70593a3 


Diff: https://reviews.apache.org/r/61824/diff/1/


Testing
-------

validated using POSTMAN REST client.


Thanks,

Sarath Subramanian


Re: Review Request 61824: [ATLAS-2078]: Updating types using v1 API doesn't route to createUpdateTypesDef in v2 API

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61824/#review183570
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 22, 2017, 10:09 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61824/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2017, 10:09 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2078
>     https://issues.apache.org/jira/browse/ATLAS-2078
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> When updating types using v1 API, if type doesn't exist we create missing types. Currently this API maps to v2 API's update method and doesn't create missing types.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java e1c5a7f5 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 7a0bbca1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java f70593a3 
> 
> 
> Diff: https://reviews.apache.org/r/61824/diff/1/
> 
> 
> Testing
> -------
> 
> validated using POSTMAN REST client.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>