You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/02 02:41:35 UTC
[GitHub] [spark] zhengruifeng commented on issue #26679: [SPARK-30044][ML]
MNB/CNB/BNB use empty sigma matrix instead of null
zhengruifeng commented on issue #26679: [SPARK-30044][ML] MNB/CNB/BNB use empty sigma matrix instead of null
URL: https://github.com/apache/spark/pull/26679#issuecomment-560203448
@srowen eh, the improvement is small:
1, we do not need to check `sigma==null` in model saving and loading
2, in the py side, the `sigma` is alwasys a matrix; while in the previous version, it is `None` when `modelType` is not `gaussian`.
Since you do not object, I will merge it these days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org