You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/28 15:38:34 UTC
[GitHub] [spark] cloud-fan opened a new pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
cloud-fan opened a new pull request #30173:
URL: https://github.com/apache/spark/pull/30173
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
For complex query plans, `QueryPlan.transformUpWithNewOutput` will keep accumulating the attributes mapping to be propagated, which may hurt performance. This PR prunes the attributes mapping before propagating.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
A simple perf improvement.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
existing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-718065938
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #30173:
URL: https://github.com/apache/spark/pull/30173#discussion_r513611501
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -180,10 +180,14 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] extends TreeNode[PlanT
* rewrite attribute references in the parent nodes.
* @param skipCond a boolean condition to indicate if we can skip transforming a plan node to save
* time.
+ * @param canGetOutput a boolean condition to indicate if we can get the output of a plan node
+ * to prune the attributes mapping to be propagated. The default value is true
+ * as only unresolved logical plan can't get output.
Review comment:
nit: Is this needed to be parameterized? Seems we only need check unresolved logical plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #30173:
URL: https://github.com/apache/spark/pull/30173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-718020231
**[Test build #130375 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130375/testReport)** for PR 30173 at commit [`4f94664`](https://github.com/apache/spark/commit/4f94664ab2736475af1ca74b2707496d6bc005e8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-718051309
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34978/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-718179708
**[Test build #130375 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130375/testReport)** for PR 30173 at commit [`4f94664`](https://github.com/apache/spark/commit/4f94664ab2736475af1ca74b2707496d6bc005e8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-718180819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu edited a comment on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
maropu edited a comment on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-718248438
Thanks! Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-718065914
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34978/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #30173:
URL: https://github.com/apache/spark/pull/30173#discussion_r513726381
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -180,10 +180,14 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] extends TreeNode[PlanT
* rewrite attribute references in the parent nodes.
* @param skipCond a boolean condition to indicate if we can skip transforming a plan node to save
* time.
+ * @param canGetOutput a boolean condition to indicate if we can get the output of a plan node
+ * to prune the attributes mapping to be propagated. The default value is true
+ * as only unresolved logical plan can't get output.
Review comment:
Oh, I see. Make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30173:
URL: https://github.com/apache/spark/pull/30173#discussion_r513650549
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -180,10 +180,14 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] extends TreeNode[PlanT
* rewrite attribute references in the parent nodes.
* @param skipCond a boolean condition to indicate if we can skip transforming a plan node to save
* time.
+ * @param canGetOutput a boolean condition to indicate if we can get the output of a plan node
+ * to prune the attributes mapping to be propagated. The default value is true
+ * as only unresolved logical plan can't get output.
Review comment:
Do you mean something like
```
val canGetOutput = plan match {
case l: LogicalPlan => l.resolved
case _ => true
}
```
then we can remove `skipCond` as well by matching `AnalysisHelper`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaoyajun02 commented on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
gaoyajun02 commented on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-923898782
hi @cloud-fan, can you help to open backport PRs for 3.0.2? thanks!
I found that prunes the attributes mapping is not only performance optimized, it also circumvents the bug of rewriting attributes for some complex queries, e.g. https://issues.apache.org/jira/browse/SPARK-36815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30173:
URL: https://github.com/apache/spark/pull/30173#discussion_r513650549
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -180,10 +180,14 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] extends TreeNode[PlanT
* rewrite attribute references in the parent nodes.
* @param skipCond a boolean condition to indicate if we can skip transforming a plan node to save
* time.
+ * @param canGetOutput a boolean condition to indicate if we can get the output of a plan node
+ * to prune the attributes mapping to be propagated. The default value is true
+ * as only unresolved logical plan can't get output.
Review comment:
Do you mean something like
```
val canGetOutput = plan match {
case l: LogicalPlan => l.resolved
case _ => true
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-718248438
Thanks@ Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-924591919
@gaoyajun02 can you cherry-pick this commit and open the backport PR? I'm quite busy this week and I can do the backport next week if you are not able to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30173:
URL: https://github.com/apache/spark/pull/30173#discussion_r513651626
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -180,10 +180,14 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] extends TreeNode[PlanT
* rewrite attribute references in the parent nodes.
* @param skipCond a boolean condition to indicate if we can skip transforming a plan node to save
* time.
+ * @param canGetOutput a boolean condition to indicate if we can get the output of a plan node
+ * to prune the attributes mapping to be propagated. The default value is true
+ * as only unresolved logical plan can't get output.
Review comment:
One advantage of the current way is we can skip the check for optimizer rules (use the default value true).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-718065938
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-718020231
**[Test build #130375 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130375/testReport)** for PR 30173 at commit [`4f94664`](https://github.com/apache/spark/commit/4f94664ab2736475af1ca74b2707496d6bc005e8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-718018397
cc @maropu @viirya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30173: [SPARK-33272][SQL] prune the attributes mapping in QueryPlan.transformUpWithNewOutput
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30173:
URL: https://github.com/apache/spark/pull/30173#issuecomment-718180819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org