You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Jean-Louis Monteiro <jl...@tomitribe.com> on 2025/12/04 22:03:30 UTC
PR review and current status
Hi,
I've been working on some PRs and would like to give a status on them.
https://github.com/apache/activemq/pull/1536
--> Fixes a dead lock with CRON schedules and a test that got me to find
the bug
PR is pretty simple and it's green
https://github.com/apache/activemq/pull/1540
--> PR to introduce parallel executions for unit tests for activemq-stomp
module
Cuts the build from ~14min to 1min20
There are many files touched, but they are very very simple (add the
category so tests are executed in the right profile). I spent time
reviewing tests and flagging the ones that could run in parallel.
PR is green
https://github.com/apache/activemq/pull/1541
Similar to previous one but for activemq-mqtt
Cuts the build from ~21min to ~3min
It's also green
https://github.com/apache/activemq/pull/1544
Again similar to stomp and mqtt but for amqp and kahadb store
As opposed to the 2 previous ones, the gain isn't as big, because most of
the tests would need to be rewritten. Still amqp time divided by 2 and
kahadb-store not significant because it uses a lot of IO and IO is slow on
Jenkins.
It's green as well though.
https://github.com/apache/activemq/pull/1555
This one is a simple fix and quick to review. That test takes about an hour
on Jenkins to do something useless that isn't used in the tests.
Brings the execution time just for this test from an hour to a few minutes
It's green as well.
https://github.com/apache/activemq/pull/1542
I'm actively working on this one because this is the one burning more than
50% of the build time.
https://github.com/apache/activemq/pull/1537
Pretty simple, but build stopped and I can't trigger a new one, so can't do
anything more on this one.
https://github.com/apache/activemq/pull/1539
Test very slow, reviewed and merged 2 days ago I think. Thank you
I have another one or two pending/draft that I will be working on later.
As soon as it's all stable and we can reliably validate any refactoring or
change with Jenkins within a reasonable time (less than 7 hours), I'll
return to Java 25 support.
I started a branch to also start looking at JUnit upgrade from 3 to JUnit
5/6
Hope it helps
Let me know if there is anything wrong with them or if you'd like me to
focus on something else.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
Re: PR review and current status
Posted by Matt Pavlovich <ma...@apache.org>.
Hi Jean-Louis-
Thank you! This is awesome. I will start assigning The first 3 PRs to me for Review-Approve-Merge this weekend.
I have a minor fix for your changes to the SendDuplicateFromStoreTest (your test fix is more preferrable than mine since you are using the wait util)
I also just kicked a Jenkins for AMQ-9809, so we can hopefully get that one green.
Thanks!
Matt Pavlovich
> On Dec 4, 2025, at 4:03 PM, Jean-Louis Monteiro <jl...@tomitribe.com> wrote:
>
> Hi,
>
> I've been working on some PRs and would like to give a status on them.
>
> https://github.com/apache/activemq/pull/1536
> --> Fixes a dead lock with CRON schedules and a test that got me to find
> the bug
> PR is pretty simple and it's green
>
> https://github.com/apache/activemq/pull/1540
> --> PR to introduce parallel executions for unit tests for activemq-stomp
> module
> Cuts the build from ~14min to 1min20
> There are many files touched, but they are very very simple (add the
> category so tests are executed in the right profile). I spent time
> reviewing tests and flagging the ones that could run in parallel.
> PR is green
>
> https://github.com/apache/activemq/pull/1541
> Similar to previous one but for activemq-mqtt
> Cuts the build from ~21min to ~3min
> It's also green
>
> https://github.com/apache/activemq/pull/1544
> Again similar to stomp and mqtt but for amqp and kahadb store
> As opposed to the 2 previous ones, the gain isn't as big, because most of
> the tests would need to be rewritten. Still amqp time divided by 2 and
> kahadb-store not significant because it uses a lot of IO and IO is slow on
> Jenkins.
> It's green as well though.
>
> https://github.com/apache/activemq/pull/1555
> This one is a simple fix and quick to review. That test takes about an hour
> on Jenkins to do something useless that isn't used in the tests.
> Brings the execution time just for this test from an hour to a few minutes
> It's green as well.
>
> https://github.com/apache/activemq/pull/1542
> I'm actively working on this one because this is the one burning more than
> 50% of the build time.
>
> https://github.com/apache/activemq/pull/1537
> Pretty simple, but build stopped and I can't trigger a new one, so can't do
> anything more on this one.
>
> https://github.com/apache/activemq/pull/1539
> Test very slow, reviewed and merged 2 days ago I think. Thank you
>
> I have another one or two pending/draft that I will be working on later.
> As soon as it's all stable and we can reliably validate any refactoring or
> change with Jenkins within a reasonable time (less than 7 hours), I'll
> return to Java 25 support.
>
> I started a branch to also start looking at JUnit upgrade from 3 to JUnit
> 5/6
>
> Hope it helps
> Let me know if there is anything wrong with them or if you'd like me to
> focus on something else.
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@activemq.apache.org
For additional commands, e-mail: dev-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: PR review and current status
Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
Hi all,
Some status updates.
Some PRs got merged and are hopefully helping get a more stable build. From
a timing perspective, the build used to take about 7h, we are down to 4h45
which is not perfect but better. Building with Github Actions takes less
than 3h.
We have 2 pending PRs which should hopefully cut the build down to a bit
more than 4h.
Thanks everyone for the help and support
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Thu, Dec 4, 2025 at 11:03 PM Jean-Louis Monteiro <
jlmonteiro@tomitribe.com> wrote:
> Hi,
>
> I've been working on some PRs and would like to give a status on them.
>
> https://github.com/apache/activemq/pull/1536
> --> Fixes a dead lock with CRON schedules and a test that got me to find
> the bug
> PR is pretty simple and it's green
>
> https://github.com/apache/activemq/pull/1540
> --> PR to introduce parallel executions for unit tests for activemq-stomp
> module
> Cuts the build from ~14min to 1min20
> There are many files touched, but they are very very simple (add the
> category so tests are executed in the right profile). I spent time
> reviewing tests and flagging the ones that could run in parallel.
> PR is green
>
> https://github.com/apache/activemq/pull/1541
> Similar to previous one but for activemq-mqtt
> Cuts the build from ~21min to ~3min
> It's also green
>
> https://github.com/apache/activemq/pull/1544
> Again similar to stomp and mqtt but for amqp and kahadb store
> As opposed to the 2 previous ones, the gain isn't as big, because most of
> the tests would need to be rewritten. Still amqp time divided by 2 and
> kahadb-store not significant because it uses a lot of IO and IO is slow on
> Jenkins.
> It's green as well though.
>
> https://github.com/apache/activemq/pull/1555
> This one is a simple fix and quick to review. That test takes about an
> hour on Jenkins to do something useless that isn't used in the tests.
> Brings the execution time just for this test from an hour to a few minutes
> It's green as well.
>
> https://github.com/apache/activemq/pull/1542
> I'm actively working on this one because this is the one burning more than
> 50% of the build time.
>
> https://github.com/apache/activemq/pull/1537
> Pretty simple, but build stopped and I can't trigger a new one, so can't
> do anything more on this one.
>
> https://github.com/apache/activemq/pull/1539
> Test very slow, reviewed and merged 2 days ago I think. Thank you
>
> I have another one or two pending/draft that I will be working on later.
> As soon as it's all stable and we can reliably validate any refactoring or
> change with Jenkins within a reasonable time (less than 7 hours), I'll
> return to Java 25 support.
>
> I started a branch to also start looking at JUnit upgrade from 3 to JUnit
> 5/6
>
> Hope it helps
> Let me know if there is anything wrong with them or if you'd like me to
> focus on something else.
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>