You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "jrudolph (via GitHub)" <gi...@apache.org> on 2023/02/22 10:05:52 UTC
[GitHub] [incubator-pekko-http] jrudolph opened a new pull request, #80: use sbt-hackers-digest
jrudolph opened a new pull request, #80:
URL: https://github.com/apache/incubator-pekko-http/pull/80
This is a new plugin I'm working on. It will annotate compilation errors, warnings, and test failures on
the relevant files in Github Actions.
I added a test failure to show the result here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #80: use sbt-hackers-digest
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #80:
URL: https://github.com/apache/incubator-pekko-http/pull/80#issuecomment-1439782583
Interesting, our test reporter also reports the tests as annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #80: use sbt-hackers-digest
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #80:
URL: https://github.com/apache/incubator-pekko-http/pull/80#issuecomment-1442083291
On another note, I was wondering if you combine this sbt plugin with `addSbtPlugin("com.hpe.sbt" % "sbt-pull-request-validator" % "1.0.0")` (which is used in pekko), would it only report annotations for code that has changed in the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #80: use sbt-hackers-digest
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #80:
URL: https://github.com/apache/incubator-pekko-http/pull/80#issuecomment-1446536110
> On another note, I was wondering if you combine this sbt plugin with `addSbtPlugin("com.hpe.sbt" % "sbt-pull-request-validator" % "1.0.0")` (which is used in pekko), would it only report annotations for code that has changed in the PR?
It reports for whatever is compiled. The sbt-pull-request-validator plugin decides that on a module by module basis, so it would still compile (and report) a lot more than just the changed files.
Also, Github has quite limiting bounds on how many annotations will be added per workflow run, so, if e.g. only a small part of big amount of warnings will ever be shown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #80: use sbt-hackers-digest
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #80:
URL: https://github.com/apache/incubator-pekko-http/pull/80#issuecomment-1442067954
This is looking really nice! Something that you might want to consider later is that there is merit in putting this sought of plugin into sbt org, I have already done this for https://github.com/sbt/sbt-github-actions (which I maintain).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph merged pull request #80: use sbt-hackers-digest
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph merged PR #80:
URL: https://github.com/apache/incubator-pekko-http/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #80: use sbt-hackers-digest
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #80:
URL: https://github.com/apache/incubator-pekko-http/pull/80#issuecomment-1441691324
(Test annotations still available as a sample of the output at https://github.com/apache/incubator-pekko-http/commit/0b85f0cf4b635bb7d99885fbd3e955b95908ef07).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #80: use sbt-hackers-digest
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #80:
URL: https://github.com/apache/incubator-pekko-http/pull/80#issuecomment-1441662185
Right now the output is a bit verbose on the "Files Changed" tab because we have multiple tools and multiple test runs annotate the same (or mostly the same) lines multiple times. I think in summary it's still better than sifting through failed run logs:
For compilation warnings/errors:
I'm now removing the test failure commit to un-draft this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org