You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ko...@apache.org on 2018/09/11 06:27:53 UTC
[arrow] branch master updated: ARROW-3217: [C++] Add missing
ARROW_STATIC definition in MinGW build
This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 05d204d ARROW-3217: [C++] Add missing ARROW_STATIC definition in MinGW build
05d204d is described below
commit 05d204d1673728f3ff844a53124ff2f23282becd
Author: Kouhei Sutou <ko...@clear-code.com>
AuthorDate: Tue Sep 11 15:27:35 2018 +0900
ARROW-3217: [C++] Add missing ARROW_STATIC definition in MinGW build
Author: Kouhei Sutou <ko...@clear-code.com>
Closes #2542 from kou/cpp-add-missing-arrow-static-definition-with-mingw and squashes the following commits:
e6a0bb6c <Kouhei Sutou> Add missing ARROW_STATIC definition in MinGW build
---
cpp/src/arrow/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
index 4937378..8eb9ed3 100644
--- a/cpp/src/arrow/CMakeLists.txt
+++ b/cpp/src/arrow/CMakeLists.txt
@@ -160,7 +160,7 @@ foreach(LIB_TARGET ${ARROW_LIBRARIES})
PRIVATE ARROW_EXPORTING)
endforeach()
-if (ARROW_BUILD_STATIC AND MSVC)
+if (ARROW_BUILD_STATIC AND WIN32)
target_compile_definitions(arrow_static PUBLIC ARROW_STATIC)
endif()