You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/16 07:56:16 UTC

[GitHub] [maven-artifact-plugin] hboutemy commented on a change in pull request #3: Maven 3.1.1 minimum

hboutemy commented on a change in pull request #3:
URL: https://github.com/apache/maven-artifact-plugin/pull/3#discussion_r558823015



##########
File path: pom.xml
##########
@@ -96,7 +96,7 @@
     <dependency>
       <groupId>org.apache.maven.resolver</groupId>
       <artifactId>maven-resolver-api</artifactId>
-      <version>1.4.1</version>

Review comment:
       perhaps we should mark such dependencies as provided: at least it would explain why we half care (it's not the version we'll have at runtime)
   
   for Maven 4: this is perhaps some case where we could remove one more version tag = "we want to make explicit that we use that library, but with the version that comes from transitive"
   
   I also prefer consistency (with a comment explaining it, because it's not obvious from an external reader point of view)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org