You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/21 15:13:49 UTC

[GitHub] [kafka] Nathan22177 commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

Nathan22177 commented on pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#issuecomment-824141690


   @mjsax 
   > MeteredSessionStore:
   > 
   > * put() (should verify `sessionKey != null` and `sessionKey.key() != null`)
   > * remove()
   > * fetchSession()
   > * fetch(K)
   > * backwardFetch(K)
   > * fetch(K, K)
   > * backwardFetch(K, K)
   > * findSession(K, long, long)
   > * backwardFindSession
   > * findSession(K, K, long, long)
   > * backwardFindSession(K, K, long, long)
   
   All of them already had the checks. Some lacked test coverage, though. I made changes according to your comments and added some tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org