You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "yyj8 (via GitHub)" <gi...@apache.org> on 2023/04/08 13:44:14 UTC
[GitHub] [pulsar] yyj8 opened a new pull request, #20048: [improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request.
yyj8 opened a new pull request, #20048:
URL: https://github.com/apache/pulsar/pull/20048
### Motivation
In the current topic level monitoring, there is no metrics to monitor the number of send data requests and the number of messages per send request (i.e., each entry) for a topic. This is inconvenient for us to troubleshoot the following issues:
1. In cases where the client does not perform batch data writing or the batch written messages are not very reasonable, we cannot intuitively reflect through monitoring and cannot detect unreasonable business usage in a timely manner; It has a significant impact on production and consumption performance, increasing cluster load, reducing cluster performance, and increasing overall costs;
2. When we enable the production flow limiting strategy, if the flow limiting condition is triggered by the number of requests on a single connection, it is difficult to accurately locate which topic's high-frequency send data is causing it;
### Modifications
Add four metrics:
`pulsar_request_rate_in`: Topic send request rate.
`pulsar_average_msg_per_request`: Average number of messages per send request for topic.
`pulsar_producer_request_in`: producer send request rate.
`pulsar_producer_avg_msg_per_request`: Average number of messages per send request for producer.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [x] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [x] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/yyj8/pulsar/pull/6<!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #20048: [improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request.
Posted by "315157973 (via GitHub)" <gi...@apache.org>.
315157973 commented on PR #20048:
URL: https://github.com/apache/pulsar/pull/20048#issuecomment-1633504688
> > Did this PIP vote pass? Where is the issue?
> > PIP-255 is `Make the partition assignment strategy pluggable` #19806
>
> PIP must have an issue, right？
pip needs to be discussed in the dev mail list, and finally initiate a vote, at least 2 PMC +1 can pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request. [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat closed pull request #20048: [improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request.
URL: https://github.com/apache/pulsar/pull/20048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yyj8 commented on pull request #20048: [improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request.
Posted by "yyj8 (via GitHub)" <gi...@apache.org>.
yyj8 commented on PR #20048:
URL: https://github.com/apache/pulsar/pull/20048#issuecomment-1621562742
> Did this PIP vote pass? Where is the issue?
>
> PIP-255 is `Make the partition assignment strategy pluggable` #19806
Pip must have an issue, right？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #20048: [improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20048:
URL: https://github.com/apache/pulsar/pull/20048#issuecomment-1588401020
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yyj8 commented on pull request #20048: [improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request.
Posted by "yyj8 (via GitHub)" <gi...@apache.org>.
yyj8 commented on PR #20048:
URL: https://github.com/apache/pulsar/pull/20048#issuecomment-1635207236
> > > Did this PIP vote pass? Where is the issue?
> > > PIP-255 is `Make the partition assignment strategy pluggable` #19806
> >
> >
> > PIP must have an issue, right？
>
> pip needs to be discussed in the dev mail list, and finally initiate a vote, at least 2 PMC +1 can pass
Do I still need to send an email to the development mailing list？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #20048: [improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20048:
URL: https://github.com/apache/pulsar/pull/20048#issuecomment-1700227430
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request. [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on PR #20048:
URL: https://github.com/apache/pulsar/pull/20048#issuecomment-6182310880
Hi @yyj8, thanks for the contribution. As mentioned in the review, PIP-255 is a different proposal, and new metrics like these would need their own PIP voted on dev@. The change hasn't found a reviewer since, and the metrics code has changed a lot, with OpenTelemetry metrics added alongside the Prometheus ones, so it would need a fresh start. We're going through the backlog of open PRs (https://lists.apache.org/thread/cgy7w0qgnq8s7j0ykyzgrn3hj4nb67wf), so I'm closing this one. If you'd like to continue, a PIP on dev@ is the way forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request. [pulsar]
Posted by "yyj8 (via GitHub)" <gi...@apache.org>.
yyj8 commented on PR #20048:
URL: https://github.com/apache/pulsar/pull/20048#issuecomment-1876961086
> > > Did this PIP vote pass? Where is the issue?
> > > PIP-255 is `Make the partition assignment strategy pluggable` #19806
> >
> >
> > PIP must have an issue, right？
>
> pip needs to be discussed in the dev mail list, and finally initiate a vote, at least 2 PMC +1 can pass
mail list：https://lists.apache.org/thread/w4jrs57gx69xw28psn0lnzxxtxnmrllo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yyj8 commented on pull request #20048: [improve][broker]PIP-255 Add topic metrics for the number of production data requests to add a topic and the average number of messages per request.
Posted by "yyj8 (via GitHub)" <gi...@apache.org>.
yyj8 commented on PR #20048:
URL: https://github.com/apache/pulsar/pull/20048#issuecomment-1501018944
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org