You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/30 02:52:34 UTC

[GitHub] [kafka] showuon opened a new pull request #11147: KAFKA-13108: improve ConfigCommandTest test coverage

showuon opened a new pull request #11147:
URL: https://github.com/apache/kafka/pull/11147


   Follow up PR for this: https://github.com/apache/kafka/pull/10811#issuecomment-883408956, to improve `ConfigCommandTest` test coverage.
   
   Tests added:
   `shouldNotAllowAddEntityDefaultBrokerQuotaConfigWhileBrokerUpUsingZookeeper`
   `shouldNotAllowDescribeEntityDefaultBrokerWhileBrokerUpUsingZookeeper`
   `shouldSupportDescribeEntityDefaultBrokerBeforeBrokerUpUsingZookeeper`
   
   The `EntityDefault` Broker config update test is already in `testDynamicBrokerConfigUpdateUsingZooKeeper`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] showuon commented on pull request #11147: KAFKA-13108: improve ConfigCommandTest test coverage

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11147:
URL: https://github.com/apache/kafka/pull/11147#issuecomment-913896267


   @ijuma , please help take a look at the follow up PR to add tests. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] showuon commented on pull request #11147: KAFKA-13108: improve ConfigCommandTest test coverage

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11147:
URL: https://github.com/apache/kafka/pull/11147#issuecomment-889658929


   @ijuma , please take a look when available. Thank you.
   
   Failed tests are unrelated. 
   ```
       Build / JDK 16 and Scala 2.13 / org.apache.kafka.connect.integration.BlockingConnectorTest.testBlockInSinkTaskStop
       Build / JDK 16 and Scala 2.13 / kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsToLatest()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org