You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Ashish Singh <as...@cloudera.com> on 2016/02/23 19:17:47 UTC
Review Request 43890: SENTRY-1056: Get service name from Kafka's
server properties.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43890/
-----------------------------------------------------------
Review request for sentry, Dapeng Sun and Hao Hao.
Bugs: SENTRY-1056
https://issues.apache.org/jira/browse/SENTRY-1056
Repository: sentry
Description
-------
SENTRY-1056: Get service name from Kafka's server properties.
Diffs
-----
sentry-binding/sentry-binding-kafka/pom.xml bd24c20edcbffb5caee69aedddb93cb5a6c8c112
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java 9ffb971d8da51b716ece3ff5a5bbeebcc7f74e8d
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java 9e72d7890e0db3710ab0971ccbb71a32d3d36e87
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java 92e50e6452a89e676eb559a3657b17ba563bfddc
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java e75ec7eddaa1a48b731d551736859a94c08af593
Diff: https://reviews.apache.org/r/43890/diff/
Testing
-------
Ran unit tests.
Thanks,
Ashish Singh
Re: Review Request 43890: SENTRY-1056: Get service name from Kafka's
server properties.
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43890/#review121556
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On Feb. 23, 2016, 6:17 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43890/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 6:17 p.m.)
>
>
> Review request for sentry, Dapeng Sun and Hao Hao.
>
>
> Bugs: SENTRY-1056
> https://issues.apache.org/jira/browse/SENTRY-1056
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1056: Get service name from Kafka's server properties.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-kafka/pom.xml bd24c20edcbffb5caee69aedddb93cb5a6c8c112
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java 9ffb971d8da51b716ece3ff5a5bbeebcc7f74e8d
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java 9e72d7890e0db3710ab0971ccbb71a32d3d36e87
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java 92e50e6452a89e676eb559a3657b17ba563bfddc
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java e75ec7eddaa1a48b731d551736859a94c08af593
>
> Diff: https://reviews.apache.org/r/43890/diff/
>
>
> Testing
> -------
>
> Ran unit tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 43890: SENTRY-1056: Get service name from Kafka's
server properties.
Posted by Ashish Singh <as...@cloudera.com>.
> On Feb. 29, 2016, 7:29 a.m., Dapeng Sun wrote:
> > Hi Ashish, it seems we can read service name from authConf, may I know why you want to put it to Kafka server properites.
Hi Dapeng, thanks for the review. This is required for enabling multiple kafka clusters with a single sentry server.
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43890/#review121201
-----------------------------------------------------------
On Feb. 23, 2016, 6:17 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43890/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 6:17 p.m.)
>
>
> Review request for sentry, Dapeng Sun and Hao Hao.
>
>
> Bugs: SENTRY-1056
> https://issues.apache.org/jira/browse/SENTRY-1056
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1056: Get service name from Kafka's server properties.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-kafka/pom.xml bd24c20edcbffb5caee69aedddb93cb5a6c8c112
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java 9ffb971d8da51b716ece3ff5a5bbeebcc7f74e8d
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java 9e72d7890e0db3710ab0971ccbb71a32d3d36e87
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java 92e50e6452a89e676eb559a3657b17ba563bfddc
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java e75ec7eddaa1a48b731d551736859a94c08af593
>
> Diff: https://reviews.apache.org/r/43890/diff/
>
>
> Testing
> -------
>
> Ran unit tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 43890: SENTRY-1056: Get service name from Kafka's
server properties.
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43890/#review121201
-----------------------------------------------------------
Hi Ashish, it seems we can read service name from authConf, may I know why you want to put it to Kafka server properites.
- Dapeng Sun
On 二月 24, 2016, 2:17 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43890/
> -----------------------------------------------------------
>
> (Updated 二月 24, 2016, 2:17 a.m.)
>
>
> Review request for sentry, Dapeng Sun and Hao Hao.
>
>
> Bugs: SENTRY-1056
> https://issues.apache.org/jira/browse/SENTRY-1056
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1056: Get service name from Kafka's server properties.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-kafka/pom.xml bd24c20edcbffb5caee69aedddb93cb5a6c8c112
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java 9ffb971d8da51b716ece3ff5a5bbeebcc7f74e8d
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java 9e72d7890e0db3710ab0971ccbb71a32d3d36e87
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java 92e50e6452a89e676eb559a3657b17ba563bfddc
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java e75ec7eddaa1a48b731d551736859a94c08af593
>
> Diff: https://reviews.apache.org/r/43890/diff/
>
>
> Testing
> -------
>
> Ran unit tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 43890: SENTRY-1056: Get service name from Kafka's
server properties.
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43890/
-----------------------------------------------------------
(Updated March 2, 2016, 6:39 p.m.)
Review request for sentry, Dapeng Sun and Hao Hao.
Changes
-------
Remove changes from SENTRY-1098.
Bugs: SENTRY-1056
https://issues.apache.org/jira/browse/SENTRY-1056
Repository: sentry
Description
-------
SENTRY-1056: Get service name from Kafka's server properties.
Diffs (updated)
-----
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java 9ffb971d8da51b716ece3ff5a5bbeebcc7f74e8d
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java 9e72d7890e0db3710ab0971ccbb71a32d3d36e87
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java 92e50e6452a89e676eb559a3657b17ba563bfddc
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java e75ec7eddaa1a48b731d551736859a94c08af593
Diff: https://reviews.apache.org/r/43890/diff/
Testing
-------
Ran unit tests.
Thanks,
Ashish Singh
Re: Review Request 43890: SENTRY-1056: Get service name from Kafka's
server properties.
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43890/#review120351
-----------------------------------------------------------
sentry-binding/sentry-binding-kafka/pom.xml (line 74)
<https://reviews.apache.org/r/43890/#comment181783>
This will be done as part of SENTRY-1098. Had to include it to be able to submit CR.
- Ashish Singh
On Feb. 23, 2016, 6:17 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43890/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 6:17 p.m.)
>
>
> Review request for sentry, Dapeng Sun and Hao Hao.
>
>
> Bugs: SENTRY-1056
> https://issues.apache.org/jira/browse/SENTRY-1056
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1056: Get service name from Kafka's server properties.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-kafka/pom.xml bd24c20edcbffb5caee69aedddb93cb5a6c8c112
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java 9ffb971d8da51b716ece3ff5a5bbeebcc7f74e8d
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java 9e72d7890e0db3710ab0971ccbb71a32d3d36e87
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java 92e50e6452a89e676eb559a3657b17ba563bfddc
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java e75ec7eddaa1a48b731d551736859a94c08af593
>
> Diff: https://reviews.apache.org/r/43890/diff/
>
>
> Testing
> -------
>
> Ran unit tests.
>
>
> Thanks,
>
> Ashish Singh
>
>