You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/03/06 00:35:13 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #3756: Multi version generic schema provider

codelipenghui commented on a change in pull request #3756: Multi version generic schema provider
URL: https://github.com/apache/pulsar/pull/3756#discussion_r262749634
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/HttpLookupService.java
 ##########
 @@ -155,6 +156,30 @@ public String getServiceUrl() {
         return future;
     }
 
+    @Override
+    public CompletableFuture<Optional<SchemaInfo>> getSchema(TopicName topicName, byte[] version) {
 
 Review comment:
   👍
   I'm already refactor get schema in HttpLookupService and BinaryProtoLookupService.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services