[GitHub] spark pull request #21819: [SPARK-24863][SS] Report Kafka offset lag as a cu...

[HyukjinKwon <gi...@git.apache.org>]

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21819#discussion_r209518847
  
    --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/JsonUtils.scala ---
    @@ -95,4 +95,20 @@ private object JsonUtils {
         }
         Serialization.write(result)
       }
    +
    +  /**
    +   * Write per-topic partition lag as json string
    +   */
    +  def partitionLags(latestOffsets: Map[TopicPartition, Long],
    +                    processedOffsets: Map[TopicPartition, Long]): String = {
    --- End diff --
    
    nit:
    
    ```scala
    def partitionLags(
        latestOffsets: Map[TopicPartition, Long],
        processedOffsets: Map[TopicPartition, Long]): String = {
    ```
    
    per https://github.com/databricks/scala-style-guide#spacing-and-indentation
    
    Please feel free to address it with other comments later.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org