[jira] [Comment Edited] (HBASE-19706) Cells are always eclipsed by Deleted cells even if in time range scan

["Ankit Singhal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-19706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314439#comment-16314439 ] 

Ankit Singhal edited comment on HBASE-19706 at 1/6/18 12:06 PM:
----------------------------------------------------------------

I just noticed that we hide cells with deleted cells purposely in case of non-raw scan and when KEEP_DELETED_CELLS is set to false. In order to have a consistent view before and after compaction. 

{code}
 if (PrivateCellUtil.isDelete(typeByte)) {
      boolean includeDeleteMarker = seePastDeleteMarkers ? tr.withinTimeRange(timestamp)
          : tr.withinOrAfterTimeRange(timestamp);
      if (includeDeleteMarker) {
        this.deletes.add(cell);
      }
      return MatchCode.SKIP;
    }
{code}

[~anoopsamjohn], [~ram_krish], [~tedyu@apache.org] I'm sorry, my bad. it is like this from long a time in HBase, we just workaround this case in Phoenix(with PHOENIX-4277). Resolving this ticket as it is working as designed.



was (Author: ankit@apache.org):
I just noticed that we hide cells with deleted cells purposely in case of non-raw scan and when KEEP_DELETED_CELLS is set to false. Probably to have a consistent view before and after compaction. 

{code}
 if (PrivateCellUtil.isDelete(typeByte)) {
      boolean includeDeleteMarker = seePastDeleteMarkers ? tr.withinTimeRange(timestamp)
          : tr.withinOrAfterTimeRange(timestamp);
      if (includeDeleteMarker) {
        this.deletes.add(cell);
      }
      return MatchCode.SKIP;
    }
{code}

[~anoopsamjohn], [~ram_krish], [~tedyu@apache.org] if this regression is intentional, should we close this JIRA and handle the things at Phoenix side accordingly?


> Cells are always eclipsed by Deleted cells even if in time range scan
> ---------------------------------------------------------------------
>
>                 Key: HBASE-19706
>                 URL: https://issues.apache.org/jira/browse/HBASE-19706
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0-beta-1
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Critical
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19706.patch, HBASE-19706_v1.patch, HBASE-19706_v2.patch
>
>
> Deleted cells are always hiding the other cells even if the scan ran with time range having no delete marker.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)