You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/09 12:51:11 UTC

[GitHub] [spark] yaooqinn opened a new pull request #26815: [SPARK-30189][SQL] Interval from year-month/date-time string should handle whitespaces

yaooqinn opened a new pull request #26815: [SPARK-30189][SQL] Interval from year-month/date-time string should handle whitespaces
URL: https://github.com/apache/spark/pull/26815
 
 
   
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   Currently, we parse interval from multi units strings or from date-time/year-month pattern strings, the former handles all whitespace, the latter not or even spaces.
   
   ### Why are the changes needed?
   
   behavior consistency
   
   ### Does this PR introduce any user-facing change?
   yes, interval in date-time/year-month like
   ```
   select interval '\n-\t10\t 12:34:46.789\t' day to second
   -- !query 126 schema
   struct<INTERVAL '-10 days -12 hours -34 minutes -46.789 seconds':interval>
   -- !query 126 output
   -10 days -12 hours -34 minutes -46.789 seconds
   ``` 
   is valid now.
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   add ut.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org