[jira] [Commented] (FLINK-7501) Generalize leader id of RegisteredRpcConnection

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140034#comment-16140034 ] 

ASF GitHub Bot commented on FLINK-7501:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4580

    [FLINK-7501] Generalize RegisteredRpcConnection to support generic leader ids

    ## What is the purpose of the change
    
    The RegisteredRpcConnection now supports generic leader ids/fencing tokens. This
    will allow to introduce component specific leader ids/fencing tokens.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink generalizeRegisteredRpcConnection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4580
    
----
commit ce34155df99ce819ab1317877f4c7c4fb71fd8d8
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-24T13:29:47Z

    [FLINK-7501] Generalize RegisteredRpcConnection to support generic leader ids
    
    The RegisteredRpcConnection now supports generic leader ids/fencing tokens. This
    will allow to introduce component specific leader ids/fencing tokens.

----


> Generalize leader id of RegisteredRpcConnection
> -----------------------------------------------
>
>                 Key: FLINK-7501
>                 URL: https://issues.apache.org/jira/browse/FLINK-7501
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>
> The {{RegisteredRpcConnection}} only accepts {{UUIDs}} as leader ids. In order to introduce type safe ids for the different Flink components ({{JobMaster}}, {{TaskExecutor}}, {{ResourceManager}} and {{Dispatcher}}), we should generalize the {{RegisteredRpcConnection}} such that it supports all different types of leader ids/fencing tokens.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)