You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by zh...@apache.org on 2019/09/09 05:57:21 UTC

[carbondata] branch master updated: [CARBONDATA-3513] fix 'taskNo' exceeding Long.MAX_VALUE issue when execute major compaction

This is an automated email from the ASF dual-hosted git repository.

zhangzc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/carbondata.git


The following commit(s) were added to refs/heads/master by this push:
     new 8906bd2  [CARBONDATA-3513] fix 'taskNo' exceeding Long.MAX_VALUE issue when execute major compaction
8906bd2 is described below

commit 8906bd2f2a83bb7ad7d001294ff8c71ab7850237
Author: changchun wang <ch...@tendcloud.com>
AuthorDate: Thu Sep 5 16:28:41 2019 +0800

    [CARBONDATA-3513] fix 'taskNo' exceeding Long.MAX_VALUE issue when execute major compaction
    
    Probelm:
    Major compaction command runs error.
    java.lang.NumberFormatException is thrown.java.lang.NumberFormatException: For input string: "32881200100001100000"
    Through code analysis it was found that taskno is "long" type. taskno generate algorithm may generate a number bigger than "Long.MAX_VALUE". carbondata-3325 change taskno type to string. But in some places it still using long.
    
    Solution:
    Change taskno type to string.
    
    This closes #3376
---
 .../apache/carbondata/processing/merger/AbstractResultProcessor.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/processing/src/main/java/org/apache/carbondata/processing/merger/AbstractResultProcessor.java b/processing/src/main/java/org/apache/carbondata/processing/merger/AbstractResultProcessor.java
index f557e9b..951339a 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/merger/AbstractResultProcessor.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/merger/AbstractResultProcessor.java
@@ -61,7 +61,7 @@ public abstract class AbstractResultProcessor {
       carbonDataFileAttributes = new CarbonDataFileAttributes(index, loadModel.getFactTimeStamp());
     } else {
       carbonDataFileAttributes =
-          new CarbonDataFileAttributes(Long.parseLong(loadModel.getTaskNo()),
+          new CarbonDataFileAttributes(loadModel.getTaskNo(),
               loadModel.getFactTimeStamp());
     }
     carbonFactDataHandlerModel.setCarbonDataFileAttributes(carbonDataFileAttributes);