Re: [PR] feat(#4185:) add persistent state support for streampipe functions

["dominikriemer (via GitHub)" <gi...@apache.org>]

dominikriemer commented on code in PR #4186:
URL: https://github.com/apache/streampipes/pull/4186#discussion_r2841208234


##########
streampipes-service-core/src/main/java/org/apache/streampipes/service/core/migrations/AvailableMigrations.java:
##########
@@ -77,6 +78,7 @@ public List<Migration> getAvailableMigrations() {
         new RemoveObsoletePrivilegesMigration(),
         new UniqueDashboardIdMigration(),
         new AddScriptTemplateViewMigration(),
+        new AddFunctionStateViewMigration(),

Review Comment:
   The latest migration should be added to the end do avoid issues with conflicting migrations



##########
streampipes-wrapper-standalone/src/main/java/org/apache/streampipes/wrapper/standalone/function/FunctionStateStore.java:
##########
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.streampipes.wrapper.standalone.function;
+
+import org.apache.streampipes.client.StreamPipesClient;
+import org.apache.streampipes.serializers.json.JacksonSerializer;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public class FunctionStateStore<T> implements StateStore<T> {
+
+  private static final Logger LOG = LoggerFactory.getLogger(FunctionStateStore.class);
+  private static final String STATE_PAYLOAD_KEY = "payload";
+
+  private final String functionId;
+  private final StreamPipesClient client;
+  private final Class<T> stateClass;
+  private final ObjectMapper objectMapper;
+  private Map<String, Object> persistedStatePayload;
+
+  public FunctionStateStore(String functionId,
+                            StreamPipesClient client,
+                            Class<T> stateClass) {
+    this.functionId = functionId;
+    this.client = client;
+    this.stateClass = stateClass;
+    this.objectMapper = JacksonSerializer.getObjectMapper();
+  }
+
+  @Override
+  public T load(T defaultState) {
+    try {
+      var functionState = client.adminApi().getFunctionState(functionId);
+      if (functionState.isPresent()) {
+        var persistedState = functionState.get();
+        if (persistedState.containsKey(STATE_PAYLOAD_KEY)) {
+          return objectMapper.convertValue(persistedState.get(STATE_PAYLOAD_KEY), stateClass);
+        } else {
+          // Backward-compatible path for states stored before payload wrapping was introduced.
+          return objectMapper.convertValue(persistedState, stateClass);

Review Comment:
   why do we need backwards compatibility here?



##########
streampipes-model/src/main/java/org/apache/streampipes/model/function/FunctionState.java:
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.streampipes.model.function;
+
+import org.apache.streampipes.commons.constants.GenericDocTypes;
+import org.apache.streampipes.model.shared.annotation.TsModel;
+import org.apache.streampipes.model.shared.api.Storable;
+
+import com.google.gson.annotations.SerializedName;
+
+import java.util.Map;
+
+@TsModel

Review Comment:
   I think we don't need the TsModel annotation here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org