[GitHub] [cloudstack] rhtyd commented on a change in pull request #5327: s2svpn: Set initial state as Connecting

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #5327:
URL: https://github.com/apache/cloudstack/pull/5327#discussion_r690255529



##########
File path: server/src/main/java/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java
##########
@@ -347,7 +347,7 @@ public Site2SiteVpnConnection startVpnConnection(long id) throws ResourceUnavail
                 if (conn.isPassive()) {
                     conn.setState(State.Disconnected);
                 } else {
-                    conn.setState(State.Connected);
+                    conn.setState(State.Connecting);

Review comment:
       Is there any FSM or logic that ensures that connections don't get stuck in the new `Connecting` state?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org