You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "gtully (via GitHub)" <gi...@apache.org> on 2023/09/07 10:17:46 UTC

[GitHub] [activemq-artemis] gtully commented on a diff in pull request #4606: ARTEMIS-4418 use consumer delivery sequence in place message id for o…

gtully commented on code in PR #4606:
URL: https://github.com/apache/activemq-artemis/pull/4606#discussion_r1318397553


##########
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java:
##########
@@ -81,6 +81,7 @@ public class AMQConsumer {
    private boolean internalAddress = false;
    private volatile Set<MessageReference> rolledbackMessageRefs;
    private ScheduledFuture<?> delayedDispatchPrompter;
+   private long deliveredSequenceId = 0;

Review Comment:
   this needs to be volatile, in the case that the consumer referenced more than one queue, or even in the case that a queue executor  is pooled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org