[PR] RATIS-2229. Do not print the same conf values multiple times. [ratis]

["szetszwo (via GitHub)" <gi...@apache.org>]

szetszwo opened a new pull request, #1200:
URL: https://github.com/apache/ratis/pull/1200

   See RATIS-2229
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RATIS-2229. Do not print the same conf values multiple times. [ratis]

["szetszwo (via GitHub)" <gi...@apache.org>]

szetszwo merged PR #1200:
URL: https://github.com/apache/ratis/pull/1200


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RATIS-2229. Do not print the same conf values multiple times. [ratis]

["szetszwo (via GitHub)" <gi...@apache.org>]

szetszwo commented on PR #1200:
URL: https://github.com/apache/ratis/pull/1200#issuecomment-2568334375

   @adoroszlai , thanks a lot for reviewing this!
   
   > My only concern is that the conf cache is shared in the JVM -- which mostly affects "mini cluster" tests.
   
   When the key-value pairs are the same, it is okay to not printing it.
   
   This is mainly for the classes like `GrpcLogAppender`.  It will keep printing a long list of conf when it keeps restarting in some failure cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org