You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2013/03/05 07:38:08 UTC
[Apache Bloodhound] #433: Add product / global prefix in label for
external wiki handlers - after #390
#433: Add product / global prefix in label for external wiki handlers - after
#390
--------------------------+---------------
Reporter: olemis | Owner:
Type: enhancement | Status: new
Priority: major | Version:
Resolution: |
--------------------------+---------------
After applying patches for #390 expressions like `product:PREFIX:#1` will
be rendered this way `<a class="new ticket"
href="/products/PREFIX/ticket/1" title="[PREFIX] This is the summary
(new)">#1</a>` . However , according to well established TracLinks
expansion conventions it should be rendered like this `<a class="new
ticket" href="/products/PREFIX/ticket/1" title="[PREFIX] This is the
summary (new)">product:PREFIX:#1</a>`
PS: ... seems to be tough , maybe a wontfix .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/433>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #433: Add product / global prefix in label
for external wiki handlers - after #390
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#433: Add product / global prefix in label for external wiki handlers - after
#390
---------------------------+--------------------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: multiproduct | Version:
Resolution: | Keywords: product global TracLinks
---------------------------+--------------------------------------
Changes (by olemis):
* owner: => nobody
* keywords: => product global TracLinks
* component: => multiproduct
* priority: major => minor
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/433#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #433: Add product / global prefix in label
for external wiki handlers - after #390
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#433: Add product / global prefix in label for external wiki handlers - after
#390
---------------------------+--------------------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: multiproduct | Version:
Resolution: | Keywords: product global TracLinks
---------------------------+--------------------------------------
Comment (by olemis):
Two more sophisticated inconsistencies that have been detected after
comment:14:ticket:390
Firstly , `[product:PREFIX:trac-2041 Trac #2041]` will be expanded to `<a
class="missing product">trac-2041</a>` instead of `<a class="missing
product">Trac #2041</a>` .
Secondly , the following expressions
{{{
product:PREFIX:#1-⁵,42
product:PREFIX:#1,³,5,7
}}}
... are expanded like this ...
{{{
#!xml
<a class="new ticket" href="%(path_prefix)s/ticket/1"
title="%(link_title_prefix)sThis is the summary (new)">#1</a>
<a class="new ticket" href="%(path_prefix)s/ticket/1"
title="%(link_title_prefix)sThis is the summary (new)">#1</a>
}}}
rather than what would be «expected» considering non-prefixed form
{{{
#!xml
<a class="new ticket" href="%(path_prefix)s/ticket/1"
title="%(link_title_prefix)sThis is the summary (new)">#1</a>-⁵,42
<a class="new ticket" href="%(path_prefix)s/ticket/1"
title="%(link_title_prefix)sThis is the summary (new)">#1</a>,³,5,7
}}}
JFTR , the reason for this to happen is that the product: prefix makes the
TracLinks resolver to match greedy until the end (outermost match) whereas
the inner ticket shortcut stops after `#1`. Remaining characters are lost.
In the short we'll survive doing things this way ... especially because it
is possible to get the previous output by inserting quotes to explicitly
delimit the start and end of ticket link e.g.
{{{
product:"PREFIX:#1"-⁵,42
product:"PREFIX:#1",³,5,7
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/433#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker