You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "james-willis (via GitHub)" <gi...@apache.org> on 2025/01/16 02:49:43 UTC
[PR] [SEDONA-697] Make getGeometryColumnName a public function [sedona]
james-willis opened a new pull request, #1760:
URL: https://github.com/apache/sedona/pull/1760
## Did you read the Contributor Guide?
- Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
## Is this PR related to a JIRA ticket?
- Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-697. The PR name follows the format `[SEDONA-XXX] my subject`.
## What changes were proposed in this PR?
making getGeometryColumnName a public function
## How was this patch tested?
unit tests for geostats will still cover this
## Did this PR include necessary documentation updates?
- No, this PR does not affect any public API so no need to change the documentation.
while technically this function is publicly available in the code now, I'm not sure it warrants being considered a "public API".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SEDONA-697] Make getGeometryColumnName a public function [sedona]
Posted by "james-willis (via GitHub)" <gi...@apache.org>.
james-willis commented on code in PR #1760:
URL: https://github.com/apache/sedona/pull/1760#discussion_r1919016107
##########
spark/common/src/main/scala/org/apache/sedona/util/DataFrameFunctionUtils.scala:
##########
@@ -16,12 +16,12 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.sedona.stats
+package org.apache.sedona.util
import org.apache.spark.sql.DataFrame
import org.apache.spark.sql.sedona_sql.UDT.GeometryUDT
-private[stats] object Util {
+object DataFrameFunctionUtils {
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SEDONA-697] Make getGeometryColumnName a public function [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #1760:
URL: https://github.com/apache/sedona/pull/1760#discussion_r1917833417
##########
spark/common/src/main/scala/org/apache/sedona/util/DataFrameFunctionUtils.scala:
##########
@@ -16,12 +16,12 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.sedona.stats
+package org.apache.sedona.util
import org.apache.spark.sql.DataFrame
import org.apache.spark.sql.sedona_sql.UDT.GeometryUDT
-private[stats] object Util {
+object DataFrameFunctionUtils {
Review Comment:
Minor: can you make the name shorter? Like `DfUtils`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SEDONA-697] Make getGeometryColumnName a public function [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #1760:
URL: https://github.com/apache/sedona/pull/1760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org