You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "eBugs (JIRA)" <ji...@apache.org> on 2019/05/07 03:43:00 UTC
[jira] [Updated] (CASSANDRA-15114) Cassandra does not follow user's
disk_failure_policy when getWriteDirectory() runs out of disk space
[ https://issues.apache.org/jira/browse/CASSANDRA-15114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
eBugs updated CASSANDRA-15114:
------------------------------
Summary: Cassandra does not follow user's disk_failure_policy when getWriteDirectory() runs out of disk space (was: CompactionAwareWriter.getWriteDirectory() throws RuntimeException when running out of disk space)
> Cassandra does not follow user's disk_failure_policy when getWriteDirectory() runs out of disk space
> ----------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15114
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15114
> Project: Cassandra
> Issue Type: Bug
> Reporter: eBugs
> Priority: Normal
>
> Dear Cassandra developers, we are developing a tool to detect exception-related bugs in Java. Our prototype has spotted the following two {{throw}} statements whose exception class and error message indicate different error conditions.
>
> Version: Cassandra-3.11 (commit: 123113f7b887370a248669ee0db6fdf13df0146e)
> File: CASSANDRA-ROOT/src/java/org/apache/cassandra/db/compaction/writers/CompactionAwareWriter.java
> Line: 222 & 231
> {code:java}
> if (availableSpace < estimatedWriteSize)
> throw new RuntimeException(String.format("Not enough space to write %s to %s (%s available)",
> FBUtilities.prettyPrintMemory(estimatedWriteSize),
> d.location,
> FBUtilities.prettyPrintMemory(availableSpace)));{code}
> {code:java}
> d = getDirectories().getWriteableLocation(estimatedWriteSize);
> if (d == null)
> throw new RuntimeException(String.format("Not enough disk space to store %s",
> FBUtilities.prettyPrintMemory(estimatedWriteSize)));
> {code}
>
> {{RuntimeException}} is usually used to represent errors in the program logic (think of one of its subclasses, {{NullPointerException}}), while the error messages indicate that the Cassandra node is running out of disk space. This mismatch could be a problem. For example, the callers may miss the possibility that {{getWriteDirectory()}} can run out of disk space because it does not throw an accurate exception class (e.g., CASSANDRA-11448). Or, the callers trying to handle other {{RuntimeException}} may accidentally (and incorrectly) handle the out of disk space scenario.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org