You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Ittay Dror (JIRA)" <ji...@apache.org> on 2008/11/06 10:13:44 UTC

[jira] Created: (BUILDR-206) transitive method does not work for projects

transitive method does not work for projects
--------------------------------------------

                 Key: BUILDR-206
                 URL: https://issues.apache.org/jira/browse/BUILDR-206
             Project: Buildr
          Issue Type: Bug
          Components: Dependency management
    Affects Versions: 1.3.2
            Reporter: Ittay Dror
             Fix For: 1.3.4


when passing a Project object to #transitive it matches the Project clause in 'case' , it then calls itself recursively with the packages of the project. these fall in the 'when Rake::Task' clause. If they are "spec" packages,  the method again recursively calls itself. this time the clause is /([^:]+:){2,4}/ which then tries to load the pom from the repository. there's no reason why there will be a pom there.  if the packages are 'file' packages, they are used as-is.

in both cases, there is no transitivity of dependencies. 

suggestion:
* add :project attribute to package tasks
* in Rake::Task clause, if the artifact responds to :project, then call recursively with the project
* in Project clause, add the packages to the result set and call recursively with spec.compile.dependencies (which can then be artifacts or packages)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (BUILDR-206) transitive method does not work for projects

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645587#action_12645587 ] 

Assaf Arkin commented on BUILDR-206:
------------------------------------

Transitive is for people who work with POMs and eager to use something until we work out transitive dependency support in the framework.

> transitive method does not work for projects
> --------------------------------------------
>
>                 Key: BUILDR-206
>                 URL: https://issues.apache.org/jira/browse/BUILDR-206
>             Project: Buildr
>          Issue Type: Bug
>          Components: Dependency management
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> when passing a Project object to #transitive it matches the Project clause in 'case' , it then calls itself recursively with the packages of the project. these fall in the 'when Rake::Task' clause. If they are "spec" packages,  the method again recursively calls itself. this time the clause is /([^:]+:){2,4}/ which then tries to load the pom from the repository. there's no reason why there will be a pom there.  if the packages are 'file' packages, they are used as-is.
> in both cases, there is no transitivity of dependencies. 
> suggestion:
> * add :project attribute to package tasks
> * in Rake::Task clause, if the artifact responds to :project, then call recursively with the project
> * in Project clause, add the packages to the result set and call recursively with spec.compile.dependencies (which can then be artifacts or packages)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (BUILDR-206) transitive method does not work for projects

Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645580#action_12645580 ] 

Ittay Dror commented on BUILDR-206:
-----------------------------------

so transitive is a complex replacement to 'project.packages'?

> transitive method does not work for projects
> --------------------------------------------
>
>                 Key: BUILDR-206
>                 URL: https://issues.apache.org/jira/browse/BUILDR-206
>             Project: Buildr
>          Issue Type: Bug
>          Components: Dependency management
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> when passing a Project object to #transitive it matches the Project clause in 'case' , it then calls itself recursively with the packages of the project. these fall in the 'when Rake::Task' clause. If they are "spec" packages,  the method again recursively calls itself. this time the clause is /([^:]+:){2,4}/ which then tries to load the pom from the repository. there's no reason why there will be a pom there.  if the packages are 'file' packages, they are used as-is.
> in both cases, there is no transitivity of dependencies. 
> suggestion:
> * add :project attribute to package tasks
> * in Rake::Task clause, if the artifact responds to :project, then call recursively with the project
> * in Project clause, add the packages to the result set and call recursively with spec.compile.dependencies (which can then be artifacts or packages)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (BUILDR-206) transitive method does not work for projects

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Assaf Arkin resolved BUILDR-206.
--------------------------------

    Resolution: Invalid

The spec says "transitive should accept project and return all its packaging tasks", and it passes.  Buildr 1.3.x packages do not contain more information than that, transitive dependency support is planned for 1.4.  1.4 will likely not use the transitive method, so not adding spec to transitive.

> transitive method does not work for projects
> --------------------------------------------
>
>                 Key: BUILDR-206
>                 URL: https://issues.apache.org/jira/browse/BUILDR-206
>             Project: Buildr
>          Issue Type: Bug
>          Components: Dependency management
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> when passing a Project object to #transitive it matches the Project clause in 'case' , it then calls itself recursively with the packages of the project. these fall in the 'when Rake::Task' clause. If they are "spec" packages,  the method again recursively calls itself. this time the clause is /([^:]+:){2,4}/ which then tries to load the pom from the repository. there's no reason why there will be a pom there.  if the packages are 'file' packages, they are used as-is.
> in both cases, there is no transitivity of dependencies. 
> suggestion:
> * add :project attribute to package tasks
> * in Rake::Task clause, if the artifact responds to :project, then call recursively with the project
> * in Project clause, add the packages to the result set and call recursively with spec.compile.dependencies (which can then be artifacts or packages)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.