You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/14 17:59:45 UTC
[GitHub] [spark] cloud-fan opened a new pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
cloud-fan opened a new pull request #30765:
URL: https://github.com/apache/spark/pull/30765
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
If we call `SubqueryExec.executeTake`, it will call `SubqueryExec.execute` which will trigger the codegen of the query plan and create an RDD. However, `SubqueryExec` already has a thread (`SubqueryExec.relationFuture`) to execute the query plan, which means we have 2 threads triggering codegen of the same query plan at the same time.
Spark codegen is not thread-safe, as we have places like `HashAggregateExec.bufferVars` that is a shared variable. The bug in `SubqueryExec` may lead to correctness bugs.
Since https://issues.apache.org/jira/browse/SPARK-33119, `ScalarSubquery` will call `SubqueryExec.executeTake`, so flaky tests start to appear.
This PR fixes the bug by overriding `executeTake` and `executeTail` in `SubqueryExec`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
fix correctness bug.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
run `build/sbt "sql/testOnly *SQLQueryTestSuite -- -z scalar-subquery-select"` more than 10 times. Previously it fails, now it passes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-745055165
**[Test build #132803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132803/testReport)** for PR 30765 at commit [`30a0f3f`](https://github.com/apache/spark/commit/30a0f3ffcb3b52b88eb3a24a7559ff72eda8899c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744715357
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37383/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744676875
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744698810
**[Test build #132781 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132781/testReport)** for PR 30765 at commit [`d66caca`](https://github.com/apache/spark/commit/d66caca006eecab6503bf80046003c53efc1d156).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class SubqueryExec(name: String, child: SparkPlan, maxNumRows: Option[Int] = None)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744651037
Oh, it becomes more complex than the initial one. @cloud-fan , is this a final?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744614306
**[Test build #132777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132777/testReport)** for PR 30765 at commit [`a5bb677`](https://github.com/apache/spark/commit/a5bb677874cad4cfcf051066a6f9c4c7bf517d1a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744715328
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37383/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744648141
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37378/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744708272
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132781/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744699523
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37383/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-745184813
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132803/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744708272
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132781/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744651849
**[Test build #132780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132780/testReport)** for PR 30765 at commit [`7dbf490`](https://github.com/apache/spark/commit/7dbf490d7d9af4d8a64b524ea1761eedafcde14f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744651199
BTW, cc @sarutak since he has an another proposal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744655338
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132780/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744655338
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132780/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744655312
**[Test build #132780 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132780/testReport)** for PR 30765 at commit [`7dbf490`](https://github.com/apache/spark/commit/7dbf490d7d9af4d8a64b524ea1761eedafcde14f).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class SubqueryExec(name: String, child: SparkPlan, maxNumRows: Option[Int])`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744614306
**[Test build #132777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132777/testReport)** for PR 30765 at commit [`a5bb677`](https://github.com/apache/spark/commit/a5bb677874cad4cfcf051066a6f9c4c7bf517d1a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744648141
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37378/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30765:
URL: https://github.com/apache/spark/pull/30765
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744610418
cc @viirya @maropu @dongjoon-hyun @wangyum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-745071824
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37405/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744635268
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37378/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30765:
URL: https://github.com/apache/spark/pull/30765#discussion_r542674121
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
##########
@@ -191,7 +194,10 @@ case class PlanSubqueries(sparkSession: SparkSession) extends Rule[SparkPlan] {
)
}
val executedPlan = QueryExecution.prepareExecutedPlan(sparkSession, query)
- InSubqueryExec(expr, SubqueryExec(s"subquery#${exprId.id}", executedPlan), exprId)
+ InSubqueryExec(
+ expr,
+ SubqueryExec(s"subquery#${exprId.id}", executedPlan, maxNumRows = None),
+ exprId)
Review comment:
So, we need this change because we don't prefer to have the default value for `maxNumRows`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744676877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-745165831
Merged to master and branch-3.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744679689
**[Test build #132781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132781/testReport)** for PR 30765 at commit [`d66caca`](https://github.com/apache/spark/commit/d66caca006eecab6503bf80046003c53efc1d156).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-745073990
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37405/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744715357
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37383/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744675689
**[Test build #132777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132777/testReport)** for PR 30765 at commit [`a5bb677`](https://github.com/apache/spark/commit/a5bb677874cad4cfcf051066a6f9c4c7bf517d1a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-745165230
**[Test build #132803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132803/testReport)** for PR 30765 at commit [`30a0f3f`](https://github.com/apache/spark/commit/30a0f3ffcb3b52b88eb3a24a7559ff72eda8899c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-745073990
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37405/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-745184813
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132803/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744651849
**[Test build #132780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132780/testReport)** for PR 30765 at commit [`7dbf490`](https://github.com/apache/spark/commit/7dbf490d7d9af4d8a64b524ea1761eedafcde14f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744999865
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744648112
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37378/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-745069654
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37405/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] Fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-745055165
**[Test build #132803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132803/testReport)** for PR 30765 at commit [`30a0f3f`](https://github.com/apache/spark/commit/30a0f3ffcb3b52b88eb3a24a7559ff72eda8899c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744679689
**[Test build #132781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132781/testReport)** for PR 30765 at commit [`d66caca`](https://github.com/apache/spark/commit/d66caca006eecab6503bf80046003c53efc1d156).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30765: [SPARK-33273][SQL] fix a race condition in subquery execution
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30765:
URL: https://github.com/apache/spark/pull/30765#issuecomment-744660630
Added more comments, it's final now. Sorry I missed the perf impact in the first commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org