[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #2201: IGNITE-19736 Do not cancel tasks in DistributionZoneManager#executor if they were created by immediate scaleUp/scaleDown events. Avoid concurrent executing several tasks for the same zone.

["sergeyuttsel (via GitHub)" <gi...@apache.org>]

sergeyuttsel commented on code in PR #2201:
URL: https://github.com/apache/ignite-3/pull/2201#discussion_r1233697235


##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -307,312 +301,6 @@ void testDropZoneDoNotPropagateDataNodesAfterScaleDown() throws Exception {
         assertZoneScaleDownChangeTriggerKey(null, ZONE_1_ID, keyValueStorage);
     }
 
-    @Test
-    void testTwoScaleUpTimersSecondTimerRunFirst() throws Exception {

Review Comment:
   This is a permanent solution. My algorithm needs a guarantee that tasks of each zone will be executed in the order they were added to the executor. These tests check that multiple tasks for a zone are running at the same time, so now such tests will not pass successfully. Even if I make a striped executor, it won't change this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org