You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "rajagopr (via GitHub)" <gi...@apache.org> on 2023/03/24 21:43:49 UTC
[GitHub] [pinot] rajagopr opened a new pull request, #10474: Upgraded joda-time library version from 2.10.5 to 2.11.2
rajagopr opened a new pull request, #10474:
URL: https://github.com/apache/pinot/pull/10474
Previously, the following query would throw an error.
```
select FromDateTime('2023-03-22', 'yyyy-MM-dd', 'Asia/Tehran') AS epochMillis
FROM ignoreMe
```
Error Gist:
```
Caused by: org.joda.time.IllegalInstantException: Cannot parse "2023-03-22": Illegal instant due to time zone offset transition (Asia/Tehran)
```
The joda-time library upgrade fixes this issue. Verified that the query works post the library version update.
For additional context see [this](https://github.com/JodaOrg/joda-time/blob/7858bb0035c05335bb2cab208f3367e5ccd7105e/src/changes/changes.xml#L56-L74) and [this](https://github.com/JodaOrg/global-tz/blame/8fa527c233c75dedb5d2857fbb96c2a40b3bcad6/asia#L1599-L1600).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 merged pull request #10474: Upgraded joda-time library version from 2.10.5 to 2.11.2
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #10474:
URL: https://github.com/apache/pinot/pull/10474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10474: Upgraded joda-time library version from 2.10.5 to 2.11.2
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10474:
URL: https://github.com/apache/pinot/pull/10474#issuecomment-1483517442
## [Codecov](https://codecov.io/gh/apache/pinot/pull/10474?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10474](https://codecov.io/gh/apache/pinot/pull/10474?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2af48e8) into [master](https://codecov.io/gh/apache/pinot/commit/11272b7eb25b915df617b783f28b06fb5ef9c87d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (11272b7) will **decrease** coverage by `56.30%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #10474 +/- ##
=============================================
- Coverage 70.27% 13.98% -56.30%
+ Complexity 6113 237 -5876
=============================================
Files 2070 2016 -54
Lines 112024 109575 -2449
Branches 17051 16778 -273
=============================================
- Hits 78725 15320 -63405
- Misses 27751 93008 +65257
+ Partials 5548 1247 -4301
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `13.98% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1612 files with indirect coverage changes](https://codecov.io/gh/apache/pinot/pull/10474/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org