You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/12 10:54:30 UTC
[GitHub] [incubator-devlake] mappjzc opened a new issue, #3393: [Bug][e2e-test] VerifyTableWithOptions Total comparison logic error
mappjzc opened a new issue, #3393:
URL: https://github.com/apache/incubator-devlake/issues/3393
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
As the code we see
The actualTotal is caculated by Db.Table
And the expectedTotal is also caculated by Db.Table
csvIter not used in here.
At this logic, it will be aceept when csvIter has more data than dbRows.
### What you expected to happen
use rigth logic to checking if the cvs file same as the databases.
### How to reproduce
1.create a cvs file with any data.
2.create an empty table.
3.use VerifyTable to cheking the table and the cvs data.
### Anything else
_No response_
### Version
main
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh closed issue #3393: [Bug][e2e-test] VerifyTableWithOptions Total comparison logic error
Posted by GitBox <gi...@apache.org>.
klesh closed issue #3393: [Bug][e2e-test] VerifyTableWithOptions Total comparison logic error
URL: https://github.com/apache/incubator-devlake/issues/3393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org