You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Raghav Gautam <ra...@gmail.com> on 2013/09/11 20:52:37 UTC
Review Request 14087: Sqoop 1196: Support for arbitrary compression codec
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14087/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: sqoop-1196
https://issues.apache.org/jira/browse/sqoop-1196
Repository: sqoop-sqoop2
Description
-------
Adding support for arbitrary compression codec for import jobs
Diffs
-----
core/src/main/java/org/apache/sqoop/framework/FrameworkValidator.java d72b9f8
core/src/main/java/org/apache/sqoop/framework/configuration/OutputCompression.java 3b5ffc5
core/src/main/java/org/apache/sqoop/framework/configuration/OutputForm.java 18eeab3
core/src/main/resources/framework-resources.properties a3d3330
core/src/test/java/org/apache/sqoop/framework/TestFrameworkValidator.java 9e1997a
execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 392007d
execution/mapreduce/src/test/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngineTest.java 19f5a22
Diff: https://reviews.apache.org/r/14087/diff/
Testing
-------
- Added unit tests
- Manually tested
- All tests pass
Thanks,
Raghav Gautam
Re: Review Request 14087: Sqoop 1196: Support for arbitrary compression codec
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14087/#review26316
-----------------------------------------------------------
Ship it!
Ship it!
core/src/test/java/org/apache/sqoop/framework/TestFrameworkValidator.java
<https://reviews.apache.org/r/14087/#comment51410>
I do like the test case's output directory :-)
Jarcec
- Jarek Cecho
On Sept. 11, 2013, 6:52 p.m., Raghav Gautam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14087/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2013, 6:52 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: sqoop-1196
> https://issues.apache.org/jira/browse/sqoop-1196
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Adding support for arbitrary compression codec for import jobs
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/framework/FrameworkValidator.java d72b9f8
> core/src/main/java/org/apache/sqoop/framework/configuration/OutputCompression.java 3b5ffc5
> core/src/main/java/org/apache/sqoop/framework/configuration/OutputForm.java 18eeab3
> core/src/main/resources/framework-resources.properties a3d3330
> core/src/test/java/org/apache/sqoop/framework/TestFrameworkValidator.java 9e1997a
> execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 392007d
> execution/mapreduce/src/test/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngineTest.java 19f5a22
>
> Diff: https://reviews.apache.org/r/14087/diff/
>
>
> Testing
> -------
>
> - Added unit tests
> - Manually tested
> - All tests pass
>
>
> Thanks,
>
> Raghav Gautam
>
>
Re: Review Request 14087: Sqoop 1196: Support for arbitrary compression codec
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14087/#review26062
-----------------------------------------------------------
Ship it!
Looks good. My only thought is that we are asking users to give the custom codec irrespective of the need for the custom code (for the known compression schemes), but understand that this is dictated currently.
Jarcec/others, any comments?
- Venkat Ranganathan
On Sept. 11, 2013, 6:52 p.m., Raghav Gautam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14087/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2013, 6:52 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: sqoop-1196
> https://issues.apache.org/jira/browse/sqoop-1196
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Adding support for arbitrary compression codec for import jobs
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/framework/FrameworkValidator.java d72b9f8
> core/src/main/java/org/apache/sqoop/framework/configuration/OutputCompression.java 3b5ffc5
> core/src/main/java/org/apache/sqoop/framework/configuration/OutputForm.java 18eeab3
> core/src/main/resources/framework-resources.properties a3d3330
> core/src/test/java/org/apache/sqoop/framework/TestFrameworkValidator.java 9e1997a
> execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 392007d
> execution/mapreduce/src/test/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngineTest.java 19f5a22
>
> Diff: https://reviews.apache.org/r/14087/diff/
>
>
> Testing
> -------
>
> - Added unit tests
> - Manually tested
> - All tests pass
>
>
> Thanks,
>
> Raghav Gautam
>
>