You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan <lu...@posteo.de> on 2017/02/01 02:15:52 UTC
[PATCH] add support for zlibstat.lib in install-layout for Windows
Hi,
the zlib project's visual studio file creates static libraries named
zlibstat.lib by default. Atm SVN supports this, if it determines zlib is
in source-layout, but doesn't support it, if it determines files are in
install-layout (the detection being based on whether the zlib-path
contains an include-directory or not).
I think it would be neat, if SVN could handle also the
zlibstat.lib-named library (since it's a default name for the static
zlib library on Windows). The attached patch adds that support.
[[[
Add support for zlibstat.lib-named zlib static libraries for Windows
builds in
install-layout.
* build/generator/gen_win_dependencies.py
(_find_zlib): check for zlibstat.lib, when determining the zlib
library name
]]]
Regards,
Stefan
Re: [PATCH] add support for zlibstat.lib in install-layout for
Windows
Posted by Stefan <lu...@posteo.de>.
On 2/1/2017 11:29, Johan Corveleyn wrote:
> On Wed, Feb 1, 2017 at 3:15 AM, Stefan <lu...@posteo.de> wrote:
>> Hi,
>>
>> the zlib project's visual studio file creates static libraries named
>> zlibstat.lib by default. Atm SVN supports this, if it determines zlib is
>> in source-layout, but doesn't support it, if it determines files are in
>> install-layout (the detection being based on whether the zlib-path
>> contains an include-directory or not).
>>
>> I think it would be neat, if SVN could handle also the
>> zlibstat.lib-named library (since it's a default name for the static
>> zlib library on Windows). The attached patch adds that support.
>>
>> [[[
>> Add support for zlibstat.lib-named zlib static libraries for Windows
>> builds in
>> install-layout.
>>
>> * build/generator/gen_win_dependencies.py
>> (_find_zlib): check for zlibstat.lib, when determining the zlib
>> library name
>> ]]]
> +1 on concept (I'll let someone else review the content of the change,
> but it looks sane to me). I've been "bitten" by this lack of support
> before, with some amount of lost time before I figured out what was
> wrong, so anything that helps these kinds of auto-detections is great.
>
Comitted in r1783704.
Re: [PATCH] add support for zlibstat.lib in install-layout for Windows
Posted by Johan Corveleyn <jc...@gmail.com>.
On Wed, Feb 1, 2017 at 3:15 AM, Stefan <lu...@posteo.de> wrote:
> Hi,
>
> the zlib project's visual studio file creates static libraries named
> zlibstat.lib by default. Atm SVN supports this, if it determines zlib is
> in source-layout, but doesn't support it, if it determines files are in
> install-layout (the detection being based on whether the zlib-path
> contains an include-directory or not).
>
> I think it would be neat, if SVN could handle also the
> zlibstat.lib-named library (since it's a default name for the static
> zlib library on Windows). The attached patch adds that support.
>
> [[[
> Add support for zlibstat.lib-named zlib static libraries for Windows
> builds in
> install-layout.
>
> * build/generator/gen_win_dependencies.py
> (_find_zlib): check for zlibstat.lib, when determining the zlib
> library name
> ]]]
+1 on concept (I'll let someone else review the content of the change,
but it looks sane to me). I've been "bitten" by this lack of support
before, with some amount of lost time before I figured out what was
wrong, so anything that helps these kinds of auto-detections is great.
--
Johan