You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/08/19 07:58:12 UTC
[GitHub] [sling-org-apache-sling-distribution-core] tmaret opened a new pull request #54: SLING-10743 - Run the package cleanup task on a single instance in a …
tmaret opened a new pull request #54:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/54
…cluster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-core] tmaret commented on a change in pull request #54: SLING-10743 - Run the package cleanup task on a single instance in a …
Posted by GitBox <gi...@apache.org>.
tmaret commented on a change in pull request #54:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/54#discussion_r691989929
##########
File path: src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VaultDistributionPackageBuilderFactory.java
##########
@@ -295,6 +295,7 @@ public void activate(BundleContext context, Map<String, Object> config) {
Dictionary<String, Object> props = new Hashtable<String, Object>();
props.put(Scheduler.PROPERTY_SCHEDULER_CONCURRENT, false);
props.put(Scheduler.PROPERTY_SCHEDULER_PERIOD, cleanupDelay);
+ props.put(Scheduler.PROPERTY_SCHEDULER_RUN_ON, Scheduler.VALUE_RUN_ON_LEADER);
Review comment:
SINGLE works as well, we don't have to run this on the leader. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-core] actinium15 commented on a change in pull request #54: SLING-10743 - Run the package cleanup task on a single instance in a …
Posted by GitBox <gi...@apache.org>.
actinium15 commented on a change in pull request #54:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/54#discussion_r691879846
##########
File path: src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VaultDistributionPackageBuilderFactory.java
##########
@@ -295,6 +295,7 @@ public void activate(BundleContext context, Map<String, Object> config) {
Dictionary<String, Object> props = new Hashtable<String, Object>();
props.put(Scheduler.PROPERTY_SCHEDULER_CONCURRENT, false);
props.put(Scheduler.PROPERTY_SCHEDULER_PERIOD, cleanupDelay);
+ props.put(Scheduler.PROPERTY_SCHEDULER_RUN_ON, Scheduler.VALUE_RUN_ON_LEADER);
Review comment:
how about?
```suggestion
props.put(Scheduler.PROPERTY_SCHEDULER_RUN_ON, Scheduler.VALUE_RUN_ON_SINGLE);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-core] actinium15 commented on a change in pull request #54: SLING-10743 - Run the package cleanup task on a single instance in a …
Posted by GitBox <gi...@apache.org>.
actinium15 commented on a change in pull request #54:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/54#discussion_r691879846
##########
File path: src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VaultDistributionPackageBuilderFactory.java
##########
@@ -295,6 +295,7 @@ public void activate(BundleContext context, Map<String, Object> config) {
Dictionary<String, Object> props = new Hashtable<String, Object>();
props.put(Scheduler.PROPERTY_SCHEDULER_CONCURRENT, false);
props.put(Scheduler.PROPERTY_SCHEDULER_PERIOD, cleanupDelay);
+ props.put(Scheduler.PROPERTY_SCHEDULER_RUN_ON, Scheduler.VALUE_RUN_ON_LEADER);
Review comment:
how about?
```suggestion
props.put(Scheduler.PROPERTY_SCHEDULER_RUN_ON, Scheduler. VALUE_RUN_ON_SINGLE);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-core] tmaret merged pull request #54: SLING-10743 - Run the package cleanup task on a single instance in a …
Posted by GitBox <gi...@apache.org>.
tmaret merged pull request #54:
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org