You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/05/01 10:54:21 UTC

[GitHub] [airflow] OmerJog commented on issue #5018: [AIRFLOW-4158] Prefix and delimiter support for S3CopyObjectOperator & S3DeleteObjectsOperator

OmerJog commented on issue #5018: [AIRFLOW-4158] Prefix and delimiter support for S3CopyObjectOperator & S3DeleteObjectsOperator
URL: https://github.com/apache/airflow/pull/5018#issuecomment-488256034
 
 
   @sherifkk 
   You have `flake8 `errors to resolve:
   ```
   ./airflow/contrib/operators/s3_delete_objects_operator.py:35:1: W293 blank line contains whitespace
   ./airflow/contrib/operators/s3_delete_objects_operator.py:48:49: W291 trailing whitespace
   ./airflow/contrib/operators/s3_delete_objects_operator.py:102:21: E126 continuation line over-indented for hanging indent
   ./airflow/contrib/operators/s3_copy_object_operator.py:33:45: W291 trailing whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:39:43: W291 trailing whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:42:1: W293 blank line contains whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:50:1: W293 blank line contains whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:52:91: W291 trailing whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:93:12: E999 SyntaxError: non-default argument follows default argument
   ./airflow/contrib/operators/s3_copy_object_operator.py:128:21: E126 continuation line over-indented for hanging indent
   ./airflow/contrib/operators/s3_copy_object_operator.py:131:1: W293 blank line contains whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:132:51: E231 missing whitespace after ','
   ./airflow/contrib/operators/s3_copy_object_operator.py:139:1: W293 blank line contains whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:143:68: W291 trailing whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:146:1: W293 blank line contains whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:148:17: E128 continuation line under-indented for visual indent
   ./airflow/contrib/operators/s3_copy_object_operator.py:149:17: E128 continuation line under-indented for visual indent
   ./airflow/contrib/operators/s3_copy_object_operator.py:154:1: W293 blank line contains whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:161:1: W293 blank line contains whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:163:33: E128 continuation line under-indented for visual indent
   ./airflow/contrib/operators/s3_copy_object_operator.py:164:33: E128 continuation line under-indented for visual indent
   ./airflow/contrib/operators/s3_copy_object_operator.py:168:14: W291 trailing whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:172:38: E225 missing whitespace around operator
   ./airflow/contrib/operators/s3_copy_object_operator.py:172:60: E226 missing whitespace around arithmetic operator
   ./airflow/contrib/operators/s3_copy_object_operator.py:176:1: W293 blank line contains whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:181:1: W293 blank line contains whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:183:33: E128 continuation line under-indented for visual indent
   ./airflow/contrib/operators/s3_copy_object_operator.py:184:33: E128 continuation line under-indented for visual indent
   ./airflow/contrib/operators/s3_copy_object_operator.py:185:1: W293 blank line contains whitespace
   ./airflow/contrib/operators/s3_copy_object_operator.py:187:13: E303 too many blank lines (2)
   ```
   
   and `mypy `error:
   `airflow/contrib/operators/s3_copy_object_operator.py:93: error: non-default argument follows default argument`
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services