You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/02/12 18:37:54 UTC

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2888: GOBBLIN-1048: Provide an option to pass and set System properties via…

autumnust commented on a change in pull request #2888: GOBBLIN-1048: Provide an option to pass and set System properties via…
URL: https://github.com/apache/incubator-gobblin/pull/2888#discussion_r378437965
 
 

 ##########
 File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterManager.java
 ##########
 @@ -150,6 +150,10 @@ public GobblinClusterManager(String clusterName, String applicationId, Config co
 
     this.applicationId = applicationId;
 
+    //Helix uses System#getProperty() for ZK configuration overrides such as sessionTimeout. The overrides specified
 
 Review comment:
   Since this is useful for any configuration, let's fix the comment which gives me impression that only ZK configuration's overrides are loaded from system configuration. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services