You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2015/12/02 00:24:09 UTC
[GitHub] flink pull request: [FLINK-3097] [table] Add support for custom fu...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/1429
[FLINK-3097] [table] Add support for custom functions in Table API
As described in FLINK-3097, this PR implements the possibility of adding custom row functions for the Table API.
In the tests you can find some examples how custom functions can look like:
```
table.select("TRIM(f0)")
table.select("SYSTEM_TIME()")
table.select("SUBSTRING(SUBSTRING(f0, 2, 5), 0, 1)")
table.select("SUBSTRING(f0, 1), SUBSTRING(f0, 2, 5)")
```
The Scala Table API is not supported yet, since I'm still waiting for #1237.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink TableApiCustomFunctions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1429.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1429
----
commit f6677487d3fe48042f521226aa4e8358433e1f9c
Author: twalthr <tw...@apache.org>
Date: 2015-11-29T15:15:16Z
[FLINK-3097] [table] Add support for custom functions in Table API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3097] [table] Add support for custom fu...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr closed the pull request at:
https://github.com/apache/flink/pull/1429
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3097] [table] Add support for custom fu...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1429#issuecomment-163680178
This looks good. :+1: Can you also integrate the support for Scala, i.e. extract it from #1237
My only concern is that it introduces yet another instance where TypeInformation is shipped to the cluster. I think we should tackle the problem at some point. Maybe generate the code on the client and ship the code as a string. Then use Janino to just compile it to a final class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3097] [table] Add support for custom fu...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1429#issuecomment-172460239
Yes, sounds good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3097] [table] Add support for custom fu...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1429#issuecomment-176845490
@twalthr Is this in the calcite branch now? Can this PR then be closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3097] [table] Add support for custom fu...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1429#issuecomment-177156151
I'm currently preparing it for the `tableOnCalcite` branch. I will close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3097] [table] Add support for custom fu...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1429#issuecomment-172459799
@fhueske I will rebase and merge this into the `tableOnCalcite` branch today, ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---