You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/02/10 02:35:27 UTC
Review Request 30812: Updated the allocator in Master::addSlave using
slave->totalResources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30812/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
Updated the allocator in Master::addSlave using slave->totalResources.
Diffs
-----
src/master/master.cpp 7c3aa220e72fdc156fb9a0998dd68beb7c464256
Diff: https://reviews.apache.org/r/30812/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 30812: Updated the allocator in Master::addSlave
using slave->totalResources.
Posted by Jie Yu <yu...@gmail.com>.
> On Feb. 11, 2015, 12:32 a.m., Ben Mahler wrote:
> > Before you commit this, mind adding a test to ensure that the checkpointed resources are offered? (in a follow up patch)
Added a test in https://reviews.apache.org/r/30900/
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30812/#review71886
-----------------------------------------------------------
On Feb. 10, 2015, 1:35 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30812/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 1:35 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the allocator in Master::addSlave using slave->totalResources.
>
>
> Diffs
> -----
>
> src/master/master.cpp 7c3aa220e72fdc156fb9a0998dd68beb7c464256
>
> Diff: https://reviews.apache.org/r/30812/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30812: Updated the allocator in Master::addSlave
using slave->totalResources.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30812/#review71886
-----------------------------------------------------------
Ship it!
Before you commit this, mind adding a test to ensure that the checkpointed resources are offered? (in a follow up patch)
- Ben Mahler
On Feb. 10, 2015, 1:35 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30812/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 1:35 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the allocator in Master::addSlave using slave->totalResources.
>
>
> Diffs
> -----
>
> src/master/master.cpp 7c3aa220e72fdc156fb9a0998dd68beb7c464256
>
> Diff: https://reviews.apache.org/r/30812/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 30812: Updated the allocator in Master::addSlave
using slave->totalResources.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30812/#review71755
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30812]
All tests passed.
- Mesos ReviewBot
On Feb. 10, 2015, 1:35 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30812/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 1:35 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the allocator in Master::addSlave using slave->totalResources.
>
>
> Diffs
> -----
>
> src/master/master.cpp 7c3aa220e72fdc156fb9a0998dd68beb7c464256
>
> Diff: https://reviews.apache.org/r/30812/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>