You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by hn...@apache.org on 2026/09/04 08:23:00 UTC
(myfaces-tobago) branch tobago-4.x updated: build(deps): checkstyle
This is an automated email from the ASF dual-hosted git repository.
henningn pushed a commit to branch tobago-4.x
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
The following commit(s) were added to refs/heads/tobago-4.x by this push:
new 2f199b0829 build(deps): checkstyle
2f199b0829 is described below
commit 2f199b08291a9e0736afd3f119d347f44ac3065c
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Fri Sep 4 10:16:42 2026 +0200
build(deps): checkstyle
Update checkstyle and fix findings.
---
pom.xml | 2 +-
.../myfaces/tobago/internal/component/AbstractUISelectBoolean.java | 2 +-
.../myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java | 2 +-
.../java/org/apache/myfaces/tobago/example/demo/EventController.java | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/pom.xml b/pom.xml
index c4a3417261..d6e2cb0152 100644
--- a/pom.xml
+++ b/pom.xml
@@ -388,7 +388,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <version>14.0.0</version>
+ <version>14.1.0</version>
</dependency>
</dependencies>
</plugin>
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectBoolean.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectBoolean.java
index d4de05d3d9..c21e8bfc07 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectBoolean.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISelectBoolean.java
@@ -52,7 +52,7 @@ public boolean isSelected() {
@Override
protected void validateValue(final FacesContext facesContext, final Object convertedValue) {
if (isRequired()) {
- if (convertedValue instanceof Boolean && !((Boolean) convertedValue)
+ if (convertedValue instanceof Boolean && !(Boolean) convertedValue
// String: e. g. if there is no ValueExpression
|| convertedValue instanceof String && !Boolean.parseBoolean((String) convertedValue)) {
MessageUtils.addMessage(
diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
index ca4502ef9e..ec7e7d560b 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java
@@ -640,7 +640,7 @@ private void encodeTableBody(
}
final Object rowRendered = sheet.getAttributes().get("rowRendered");
- if (rowRendered instanceof Boolean && !((Boolean) rowRendered)) {
+ if (rowRendered instanceof Boolean && !(Boolean) rowRendered) {
continue;
}
diff --git a/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/EventController.java b/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/EventController.java
index e467fbf3e2..90f09caa95 100644
--- a/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/EventController.java
+++ b/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/EventController.java
@@ -191,7 +191,7 @@ public String getEventName() {
public void selectComponent(final ActionEvent actionEvent) {
final UIData data = ComponentUtils.findAncestor(actionEvent.getComponent(), UIData.class);
- selectedComponent = data != null ? ((EventsOnComponent) data.getRowData()) : null;
+ selectedComponent = data != null ? (EventsOnComponent) data.getRowData() : null;
eventName = actionEvent.getComponent().getAttributes().get("eventName").toString();
}