You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by og...@apache.org on 2006/11/26 20:33:18 UTC
svn commit: r479413 - in
/jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http:
impl/entity/ message/
Author: oglueck
Date: Sun Nov 26 11:33:18 2006
New Revision: 479413
URL: http://svn.apache.org/viewvc?view=rev&rev=479413
Log:
checking for 0 length is faster than comparing with empty string
Modified:
jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/entity/LaxContentLengthStrategy.java
jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicHeaderElement.java
jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java
jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicStatusLine.java
jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BufferedHeader.java
Modified: jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/entity/LaxContentLengthStrategy.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/entity/LaxContentLengthStrategy.java?view=diff&rev=479413&r1=479412&r2=479413
==============================================================================
--- jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/entity/LaxContentLengthStrategy.java (original)
+++ jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/entity/LaxContentLengthStrategy.java Sun Nov 26 11:33:18 2006
@@ -199,7 +199,7 @@
// Currently only chunk and identity are supported
for (int i = 0; i < encodings.length; i++) {
String encoding = encodings[i].getName();
- if (encoding != null && !encoding.equals("")
+ if (encoding != null && encoding.length() > 0
&& !encoding.equalsIgnoreCase(HTTP.CHUNK_CODING)
&& !encoding.equalsIgnoreCase(HTTP.IDENTITY_CODING)) {
throw new ProtocolException("Unsupported transfer encoding: " + encoding);
Modified: jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicHeaderElement.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicHeaderElement.java?view=diff&rev=479413&r1=479412&r2=479413
==============================================================================
--- jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicHeaderElement.java (original)
+++ jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicHeaderElement.java Sun Nov 26 11:33:18 2006
@@ -218,7 +218,7 @@
} else if (cur == indexTo - 1) {
element = parse(buffer, from, indexTo);
}
- if (element != null && !(element.getName().equals("") && element.getValue() == null)) {
+ if (element != null && !(element.getName().length() == 0 && element.getValue() == null)) {
elements.add(element);
}
if (escaped) {
Modified: jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java?view=diff&rev=479413&r1=479412&r2=479413
==============================================================================
--- jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java (original)
+++ jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java Sun Nov 26 11:33:18 2006
@@ -174,7 +174,7 @@
} else if (cur == indexTo - 1) {
param = parse(buffer, from, indexTo);
}
- if (param != null && !(param.getName().equals("") && param.getValue() == null)) {
+ if (param != null && !(param.getName().length() == 0 && param.getValue() == null)) {
params.add(param);
}
if (escaped) {
Modified: jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicStatusLine.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicStatusLine.java?view=diff&rev=479413&r1=479412&r2=479413
==============================================================================
--- jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicStatusLine.java (original)
+++ jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicStatusLine.java Sun Nov 26 11:33:18 2006
@@ -207,7 +207,7 @@
buffer.append(this.httpVersion);
buffer.append(' ');
buffer.append(Integer.toString(this.statusCode));
- if (this.reasonPhrase != null && !this.reasonPhrase.equals("")) {
+ if (this.reasonPhrase != null && this.reasonPhrase.length() > 0) {
buffer.append(' ');
buffer.append(this.reasonPhrase);
}
Modified: jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BufferedHeader.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BufferedHeader.java?view=diff&rev=479413&r1=479412&r2=479413
==============================================================================
--- jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BufferedHeader.java (original)
+++ jakarta/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BufferedHeader.java Sun Nov 26 11:33:18 2006
@@ -78,7 +78,7 @@
throw new IllegalArgumentException("Invalid header: " + buffer.toString());
}
String s = buffer.substringTrimmed(0, colon);
- if (s.equals("")) {
+ if (s.length() == 0) {
throw new IllegalArgumentException("Invalid header: " + buffer.toString());
}
this.buffer = buffer;