You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/25 07:45:21 UTC
[GitHub] [arrow-rs] Jimexist opened a new pull request #714: run results of `cargo --fix` for edition 2021
Jimexist opened a new pull request #714:
URL: https://github.com/apache/arrow-rs/pull/714
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #714: run results of `cargo --fix` for edition 2021
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #714:
URL: https://github.com/apache/arrow-rs/pull/714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on a change in pull request #714: run results of `cargo --fix` for edition 2021
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on a change in pull request #714:
URL: https://github.com/apache/arrow-rs/pull/714#discussion_r696837777
##########
File path: arrow/src/alloc/types.rs
##########
@@ -36,7 +36,7 @@ pub unsafe trait NativeType:
}
macro_rules! create_native {
- ($native_ty:ty,$($impl_pattern:pat)|+) => {
+ ($native_ty:ty,$($impl_pattern:pat_param)|+) => {
Review comment:
@alamb Either I have something misconfigured locally or this change breaks compilation with the version 1.52.1 configured in rust-toolchain:
```
error: invalid fragment specifier `pat_param`
--> arrow/src/alloc/types.rs:39:22
|
39 | ($native_ty:ty,$($impl_pattern:pat_param)|+) => {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: valid fragment specifiers are `ident`, `block`, `stmt`, `expr`, `pat`, `ty`, `lifetime`, `literal`, `path`, `meta`, `tt`, `item` and `vis`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on a change in pull request #714: run results of `cargo --fix` for edition 2021
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on a change in pull request #714:
URL: https://github.com/apache/arrow-rs/pull/714#discussion_r697265794
##########
File path: arrow/src/alloc/types.rs
##########
@@ -36,7 +36,7 @@ pub unsafe trait NativeType:
}
macro_rules! create_native {
- ($native_ty:ty,$($impl_pattern:pat)|+) => {
+ ($native_ty:ty,$($impl_pattern:pat_param)|+) => {
Review comment:
Just noticed `rust-toolchain` file is not part of the repo and I only added that locally at some point. That means this was actually a problem on my side, arrow-rs requiring a newer version is totally fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #714: run results of `cargo --fix` for edition 2021
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #714:
URL: https://github.com/apache/arrow-rs/pull/714#discussion_r697663939
##########
File path: arrow/src/alloc/types.rs
##########
@@ -36,7 +36,7 @@ pub unsafe trait NativeType:
}
macro_rules! create_native {
- ($native_ty:ty,$($impl_pattern:pat)|+) => {
+ ($native_ty:ty,$($impl_pattern:pat_param)|+) => {
Review comment:
@jhorstmann -- I backported this change to the proposed arrow 5.3.0. Given your experience, I think I should probably undo that change and make a new 5.3.0 RC candidate.
@Jimexist / @jhorstmann any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Jimexist commented on a change in pull request #714: run results of `cargo --fix` for edition 2021
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #714:
URL: https://github.com/apache/arrow-rs/pull/714#discussion_r697835220
##########
File path: arrow/src/alloc/types.rs
##########
@@ -36,7 +36,7 @@ pub unsafe trait NativeType:
}
macro_rules! create_native {
- ($native_ty:ty,$($impl_pattern:pat)|+) => {
+ ($native_ty:ty,$($impl_pattern:pat_param)|+) => {
Review comment:
it's either that or you note in the release notes that the minimal support rust version is 1.53.
rust edition 2021 is likely land in rust 1.56. and given my understanding that arrow does not promise a specific back-compatible yet I feel like that users are supposed to upgrade to latest stable. but my understanding could be wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Jimexist commented on a change in pull request #714: run results of `cargo --fix` for edition 2021
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #714:
URL: https://github.com/apache/arrow-rs/pull/714#discussion_r697089135
##########
File path: arrow/src/alloc/types.rs
##########
@@ -36,7 +36,7 @@ pub unsafe trait NativeType:
}
macro_rules! create_native {
- ($native_ty:ty,$($impl_pattern:pat)|+) => {
+ ($native_ty:ty,$($impl_pattern:pat_param)|+) => {
Review comment:
@alamb I think we need to somehow [pin the rust toolchain][1]
[1]: https://dev-doc.rust-lang.org/stable/edition-guide/rust-2021/or-patterns-macro-rules.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on a change in pull request #714: run results of `cargo --fix` for edition 2021
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on a change in pull request #714:
URL: https://github.com/apache/arrow-rs/pull/714#discussion_r697841832
##########
File path: arrow/src/alloc/types.rs
##########
@@ -36,7 +36,7 @@ pub unsafe trait NativeType:
}
macro_rules! create_native {
- ($native_ty:ty,$($impl_pattern:pat)|+) => {
+ ($native_ty:ty,$($impl_pattern:pat_param)|+) => {
Review comment:
> arrow does not promise a specific back-compatible yet
I now also remember that discussion and agree with it. So from my perspective it is not necessary to revert this change.
We should probably write down this policy in the README if it is not already there yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #714: run results of `cargo --fix` for edition 2021
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #714:
URL: https://github.com/apache/arrow-rs/pull/714#discussion_r697854356
##########
File path: arrow/src/alloc/types.rs
##########
@@ -36,7 +36,7 @@ pub unsafe trait NativeType:
}
macro_rules! create_native {
- ($native_ty:ty,$($impl_pattern:pat)|+) => {
+ ($native_ty:ty,$($impl_pattern:pat_param)|+) => {
Review comment:
Proposed readme changes: https://github.com/apache/arrow-rs/pull/726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Jimexist commented on a change in pull request #714: run results of `cargo --fix` for edition 2021
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #714:
URL: https://github.com/apache/arrow-rs/pull/714#discussion_r697094376
##########
File path: arrow/src/alloc/types.rs
##########
@@ -36,7 +36,7 @@ pub unsafe trait NativeType:
}
macro_rules! create_native {
- ($native_ty:ty,$($impl_pattern:pat)|+) => {
+ ($native_ty:ty,$($impl_pattern:pat_param)|+) => {
Review comment:
https://github.com/apache/arrow-rs/pull/724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org