You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/07/18 02:45:30 UTC

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #256: [IOTDB-141]Develop memory estimate tool

jixuan1989 commented on a change in pull request #256: [IOTDB-141]Develop memory estimate tool
URL: https://github.com/apache/incubator-iotdb/pull/256#discussion_r304715288
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -126,6 +126,11 @@
             <artifactId>jaxb-runtime</artifactId>
             <version>2.4.0-b180725.0644</version>
         </dependency>
+        <dependency>
+            <groupId>io.airlift</groupId>
+            <artifactId>airline</artifactId>
+            <version>0.8</version>
+        </dependency>
 
 Review comment:
   "Airlift is a framework for building REST services in Java." 
   Ah? did you add a REST service??
   by the way, we need to add comments when we add new dependencies.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services