You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/04/12 14:09:04 UTC
svn commit: r1876427 - /pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/ttf/gsub/CompoundCharacterTokenizerTest.java

Author: tilman
Date: Sun Apr 12 14:09:04 2020
New Revision: 1876427

URL: http://svn.apache.org/viewvc?rev=1876427&view=rev
Log:
PDFBOX-4071: use new method from jdk8

Modified:
    pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/ttf/gsub/CompoundCharacterTokenizerTest.java

Modified: pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/ttf/gsub/CompoundCharacterTokenizerTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/ttf/gsub/CompoundCharacterTokenizerTest.java?rev=1876427&r1=1876426&r2=1876427&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/ttf/gsub/CompoundCharacterTokenizerTest.java (original)
+++ pdfbox/trunk/fontbox/src/test/java/org/apache/fontbox/ttf/gsub/CompoundCharacterTokenizerTest.java Sun Apr 12 14:09:04 2020
@@ -42,10 +42,7 @@ public class CompoundCharacterTokenizerT
         List<String> tokens = tokenizer.tokenize(text);
 
         // then
-        StringBuilder sb = new StringBuilder();
-        tokens.forEach(token -> sb.append(token));
-
-        assertEquals(text, sb.toString());
+        assertEquals(text, String.join("", tokens));
         assertEquals(Arrays.asList("12345", "HrkJj", "xabbcc", "68RetP", "xxxcfb1245678",
                 "Yx!23uyt", "889000"), tokens);
     }
@@ -63,10 +60,7 @@ public class CompoundCharacterTokenizerT
         List<String> tokens = tokenizer.tokenize(text);
 
         // then
-        StringBuilder sb = new StringBuilder();
-        tokens.forEach(token -> sb.append(token));
-
-        assertEquals(text, sb.toString());
+        assertEquals(text, String.join("", tokens));
         assertEquals(Arrays.asList("84_112_93_", "104_82", "_61_96_102_93_", "104_87", "_110"),
                 tokens);
     }
@@ -84,10 +78,7 @@ public class CompoundCharacterTokenizerT
         List<String> tokens = tokenizer.tokenize(text);
 
         // then
-        StringBuilder sb = new StringBuilder();
-        tokens.forEach(token -> sb.append(token));
-
-        assertEquals(text, sb.toString());
+        assertEquals(text, String.join("", tokens));
         assertEquals(Arrays.asList("67_112_96", "_103_93_108_93"), tokens);
     }
 
@@ -104,10 +95,7 @@ public class CompoundCharacterTokenizerT
         List<String> tokens = tokenizer.tokenize(text);
 
         // then
-        StringBuilder sb = new StringBuilder();
-        tokens.forEach(token -> sb.append(token));
-
-        assertEquals(text, sb.toString());
+        assertEquals(text, String.join("", tokens));
         assertEquals(Arrays.asList("94_", "67_112_96", "_112_91_103"), tokens);
     }
 
@@ -124,10 +112,7 @@ public class CompoundCharacterTokenizerT
         List<String> tokens = tokenizer.tokenize(text);
 
         // then
-        StringBuilder sb = new StringBuilder();
-        tokens.forEach(token -> sb.append(token));
-
-        assertEquals(text, sb.toString());
+        assertEquals(text, String.join("", tokens));
         assertEquals(Arrays.asList("94_1", "67_112", "_91_103"), tokens);
     }
 
@@ -143,14 +128,8 @@ public class CompoundCharacterTokenizerT
         List<String> tokens = tokenizer.tokenize(text);
 
         // then
-        StringBuilder sb = new StringBuilder();
-        tokens.forEach(token -> sb.append(token));
-
-        assertEquals(text, sb.toString());
-
-        List<String> tokenList = tokens;
-
-        assertEquals(0, tokenList.indexOf("Yx!23uyt"));
+        assertEquals(text, String.join("", tokens));
+        assertEquals(0, tokens.indexOf("Yx!23uyt"));
     }
 
     @Test
@@ -165,10 +144,7 @@ public class CompoundCharacterTokenizerT
         List<String> tokens = tokenizer.tokenize(text);
 
         // then
-        StringBuilder sb = new StringBuilder();
-        tokens.forEach(token -> sb.append(token));
-
-        assertEquals(text, sb.toString());
+        assertEquals(text, String.join("", tokens));
         assertEquals(0, tokens.indexOf("Yx!23uyt"));
         assertEquals(2, tokens.indexOf("HrkJj"));
         assertEquals(tokens.size() - 1, tokens.lastIndexOf("HrkJj"));
@@ -186,15 +162,9 @@ public class CompoundCharacterTokenizerT
         List<String> tokens = tokenizer.tokenize(text);
 
         // then
-        StringBuilder sb = new StringBuilder();
-        tokens.forEach(token -> sb.append(token));
-
-        assertEquals(text, sb.toString());
-
-        List<String> tokenList = tokens;
-
-        assertTrue(tokenList.contains("\u0995\u09cd\u09b7"));
-        assertTrue(tokenList.contains("\u09aa\u09c1\u09a4\u09c1"));
+        assertEquals(text, String.join("", tokens));
+        assertTrue(tokens.contains("\u0995\u09cd\u09b7"));
+        assertTrue(tokens.contains("\u09aa\u09c1\u09a4\u09c1"));
     }
 
 }