You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2014/09/02 18:01:52 UTC

svn commit: r1622043 - in /commons/proper/pool/trunk/src: main/java/org/apache/commons/pool2/impl/ test/java/org/apache/commons/pool2/ test/java/org/apache/commons/pool2/performance/

Author: ggregory
Date: Tue Sep  2 16:01:52 2014
New Revision: 1622043

URL: http://svn.apache.org/r1622043
Log:
Remove unnecessary parentheses.

Modified:
    commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java
    commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java
    commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/MethodCall.java
    commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/performance/PerformanceTest.java

Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java?rev=1622043&r1=1622042&r2=1622043&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java (original)
+++ commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/AbandonedConfig.java Tue Sep  2 16:01:52 2014
@@ -49,7 +49,7 @@ public class AbandonedConfig {
      * @return true if abandoned objects are to be removed by borrowObject
      */
     public boolean getRemoveAbandonedOnBorrow() {
-        return (this.removeAbandonedOnBorrow);
+        return this.removeAbandonedOnBorrow;
     }
 
     /**
@@ -86,7 +86,7 @@ public class AbandonedConfig {
      * @return true if abandoned objects are to be removed by the evictor
      */
     public boolean getRemoveAbandonedOnMaintenance() {
-        return (this.removeAbandonedOnMaintenance);
+        return this.removeAbandonedOnMaintenance;
     }
 
     /**
@@ -118,7 +118,7 @@ public class AbandonedConfig {
      * @return the abandoned object timeout in seconds
      */
     public int getRemoveAbandonedTimeout() {
-        return (this.removeAbandonedTimeout);
+        return this.removeAbandonedTimeout;
     }
 
     /**
@@ -156,7 +156,7 @@ public class AbandonedConfig {
      *
      */
     public boolean getLogAbandoned() {
-        return (this.logAbandoned);
+        return this.logAbandoned;
     }
 
     /**

Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java?rev=1622043&r1=1622042&r2=1622043&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java (original)
+++ commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/LinkedBlockingDeque.java Tue Sep  2 16:01:52 2014
@@ -692,7 +692,7 @@ class LinkedBlockingDeque<E> extends Abs
     public E peekFirst() {
         lock.lock();
         try {
-            return (first == null) ? null : first.item;
+            return first == null ? null : first.item;
         } finally {
             lock.unlock();
         }
@@ -702,7 +702,7 @@ class LinkedBlockingDeque<E> extends Abs
     public E peekLast() {
         lock.lock();
         try {
-            return (last == null) ? null : last.item;
+            return last == null ? null : last.item;
         } finally {
             lock.unlock();
         }
@@ -1220,7 +1220,7 @@ class LinkedBlockingDeque<E> extends Abs
             lock.lock();
             try {
                 next = firstNode();
-                nextItem = (next == null) ? null : next.item;
+                nextItem = next == null ? null : next.item;
             } finally {
                 lock.unlock();
             }
@@ -1244,7 +1244,7 @@ class LinkedBlockingDeque<E> extends Abs
                     }
                     next = s;
                 }
-                nextItem = (next == null) ? null : next.item;
+                nextItem = next == null ? null : next.item;
             } finally {
                 lock.unlock();
             }

Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/MethodCall.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/MethodCall.java?rev=1622043&r1=1622042&r2=1622043&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/MethodCall.java (original)
+++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/MethodCall.java Tue Sep  2 16:01:52 2014
@@ -103,7 +103,7 @@ public class MethodCall {
     @Override
     public int hashCode() {
         int result;
-        result = (name != null ? name.hashCode() : 0);
+        result = name != null ? name.hashCode() : 0;
         result = 29 * result + (params != null ? params.hashCode() : 0);
         result = 29 * result + (returned != null ? returned.hashCode() : 0);
         return result;

Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/performance/PerformanceTest.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/performance/PerformanceTest.java?rev=1622043&r1=1622042&r2=1622043&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/performance/PerformanceTest.java (original)
+++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/performance/PerformanceTest.java Tue Sep  2 16:01:52 2014
@@ -81,8 +81,8 @@ public class PerformanceTest {
                 long rend = System.currentTimeMillis();
                 Thread.yield();
                 taskStats.complete++;
-                borrowTime = (bend-bbegin);
-                returnTime = (rend-rbegin);
+                borrowTime = bend-bbegin;
+                returnTime = rend-rbegin;
             } catch (Exception e) {
                 e.printStackTrace();
             }