You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Deni90 <gi...@git.apache.org> on 2016/11/03 13:40:54 UTC
[GitHub] qpid-proton pull request #84: Adds cmake libatomic check to examplex/cpp
GitHub user Deni90 opened a pull request:
https://github.com/apache/qpid-proton/pull/84
Adds cmake libatomic check to examplex/cpp
qpid-proton FTBFS on Debian for mips and mipsel with following error:
```
/usr/bin/c++ -g -O2 -fdebug-prefix-map=/�PKGBUILDDIR�=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro CMakeFiles/mt_broker.dir/mt/broker.cpp.o CMakeFiles/mt_broker.dir/mt/epoll_container.cpp.o -o mt_broker -rdynamic ../../proton-c/bindings/cpp/libqpid-proton-cpp.so.8.0.0 -lpthread ../../proton-c/libqpid-proton.so.8.0.0 -lssl -lcrypto -Wl,-rpath,/�PKGBUILDDIR�/obj-mips-linux-gnu/proton-c/bindings/cpp:/�PKGBUILDDIR�/obj-mips-linux-gnu/proton-c
CMakeFiles/mt_broker.dir/mt/epoll_container.cpp.o: In function `std::__atomic_base<unsigned long long>::operator++()':
/usr/include/c++/6/bits/atomic_base.h:296: undefined reference to `__atomic_fetch_add_8'
/usr/include/c++/6/bits/atomic_base.h:296: undefined reference to `__atomic_fetch_add_8'
CMakeFiles/mt_broker.dir/mt/broker.cpp.o: In function `std::__atomic_base<unsigned long long>::fetch_add(unsigned long long, std::memory_order)':
/usr/include/c++/6/bits/atomic_base.h:514: undefined reference to `__atomic_fetch_add_8'
/usr/include/c++/6/bits/atomic_base.h:514: undefined reference to `__atomic_fetch_add_8'
collect2: error: ld returned 1 exit status
examples/cpp/CMakeFiles/mt_broker.dir/build.make:127: recipe for target 'examples/cpp/mt_broker' failed
make[4]: *** [examples/cpp/mt_broker] Error 1
```
Full logs:
https://buildd.debian.org/status/fetch.php?pkg=qpid-proton&arch=mips&ver=0.14.0-2&stamp=1477932759
https://buildd.debian.org/status/fetch.php?pkg=qpid-proton&arch=mipsel&ver=0.14.0-2&stamp=1477941420
I added a check to figure out whether we need to link with libatomic.
This fixes the examples for 32-bit MIPS CPUs where the 8-byte atomic operations call into the libatomic library.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Deni90/qpid-proton master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
----
commit dc57ca2d8e6bb22cb0c78d359241c822ba795a24
Author: Daniel Knezevic <da...@gmail.com>
Date: 2016-11-03T13:22:27Z
Adds cmake libatomic check to examplex/cpp
This fixes the examples for 32-bit MIPS CPUs where the 8-byte atomic operations call into the libatomic library.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #84: Adds cmake libatomic check to examplex/cpp
Posted by astitcher <gi...@git.apache.org>.
Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/84
this should be fixed in SHA 722226285f04e36cdbff68e98877cbc01bf4fb53 (which should be in the 0.15 release).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #84: Adds cmake libatomic check to examplex/cpp
Posted by astitcher <gi...@git.apache.org>.
Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/84
Is this against master?
I'm pretty sure @alanconway already fixed this by completely avoiding 8 byte atomics on 32 bit platforms.
The place where 64 bit atomics are used just doesn't need them, being a simple sequence number.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton pull request #84: Adds cmake libatomic check to examplex/cpp
Posted by Deni90 <gi...@git.apache.org>.
Github user Deni90 closed the pull request at:
https://github.com/apache/qpid-proton/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #84: Adds cmake libatomic check to examplex/cpp
Posted by Deni90 <gi...@git.apache.org>.
Github user Deni90 commented on the issue:
https://github.com/apache/qpid-proton/pull/84
Sorry, I didn't see that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org