[jira] Commented: (DERBY-4317) convert columnDefaults.sql to JUNIT

["Mamta A. Satoor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736798#action_12736798 ] 

Mamta A. Satoor commented on DERBY-4317:
----------------------------------------

Thanks, Eranda,  for working on the test conversion.

One comment I had is rather than have the each test do the table creation as part of the test fixture, which makes the test code intermingle with setup code and hence takes some focus away from the actual test. Instead, may be you can consider using CleanDatabaseTestSetup decorator. One example of this usage of this decorator can be found in GroupByExpression test but there are many other tests who use this decorator. Using this decorator will allow you to overload decorateSQL method in which you can put all the create table/view/function etc sqls. 

If I have any further feedback on the rest of the converted junit test, I will post another comment but thanks again for converting the test into junit. 

> convert columnDefaults.sql to JUNIT
> -----------------------------------
>
>                 Key: DERBY-4317
>                 URL: https://issues.apache.org/jira/browse/DERBY-4317
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>         Attachments: ColumnDefaultsTest.diff, ColumnDefaultsTest.diff
>
>
> Conversion of the columnDefaults.sql to JUNIT

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.