You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2013/04/02 19:57:16 UTC

[jira] [Updated] (HDFS-4661) code style fixes suggested by Nicholas

     [ https://issues.apache.org/jira/browse/HDFS-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Patrick McCabe updated HDFS-4661:
---------------------------------------

    Attachment: HDFS-4661.001.patch

here's a patch.  I've tested it with TestDomainSocket,TestShortCircuitLocalRead,TestParallelShortCircuitRead,TestParallelRead,TestPersistBlocks,TestPeerCache,TestFileInputStreamCache,TestParallelUnixDomainRead,TestParallelShortCircuitReadNoChecksum,TestBlockReaderLocal,TestBlockReaderLocalLegacy
                
> code style fixes suggested by Nicholas
> --------------------------------------
>
>                 Key: HDFS-4661
>                 URL: https://issues.apache.org/jira/browse/HDFS-4661
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, hdfs-client, performance
>            Reporter: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-4661.001.patch
>
>
> * The log statement in DataXceiver "BlockSender.ClientTraceLog.info("REQUEST_SHORT_CIRCUIT_FDS"...)" could be cleaned up somewhat.
> * use {{FsDatasetSpi#getBlockInputStream}} and {{FsDatasetSpi#getMetaDataInputStream}} rather than adding {{FsDatasetSpi#getShortCircuitFdsForRead}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira