You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/12/02 13:27:00 UTC
[jira] [Commented] (HDFS-16859) acquirePermit : move LOG.debug into if condition
[ https://issues.apache.org/jira/browse/HDFS-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642501#comment-17642501 ]
ASF GitHub Bot commented on HDFS-16859:
---------------------------------------
hfutatzhanghb opened a new pull request, #5181:
URL: https://github.com/apache/hadoop/pull/5181
…rmit.
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
The invoke frequency of method AbstractRouterRpcFairnessPolicyController#acquirePermit is high. before getting the permit of a nameservice, there is always a LOG.debug statement.
It is better to move the statement into if condition statement.
### How was this patch tested?
no need to test.
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
> acquirePermit : move LOG.debug into if condition
> ------------------------------------------------
>
> Key: HDFS-16859
> URL: https://issues.apache.org/jira/browse/HDFS-16859
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Affects Versions: 3.3.4
> Reporter: ZhangHB
> Priority: Major
>
> The invoke frequency of method AbstractRouterRpcFairnessPolicyController#acquirePermit is high. before getting the permit of a nameservice, there is always a LOG.debug statement.
> It is better to move the statement into if condition statement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org