You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2009/06/15 00:01:07 UTC
[jira] Created: (CASSANDRA-230) Race in ChecksumManager.instance()
Race in ChecksumManager.instance()
----------------------------------
Key: CASSANDRA-230
URL: https://issues.apache.org/jira/browse/CASSANDRA-230
Project: Cassandra
Issue Type: Bug
Affects Versions: trunk
Reporter: Stu Hood
There is a minor race condition in ChecksumManager.instance(). Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-230) Race in ChecksumManager.instance()
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-230:
-------------------------------------
Attachment: 230.patch
r/m CM and CRAF
> Race in ChecksumManager.instance()
> ----------------------------------
>
> Key: CASSANDRA-230
> URL: https://issues.apache.org/jira/browse/CASSANDRA-230
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Stu Hood
> Attachments: 230.patch, checksum-manager-race.patch
>
>
> There is a minor race condition in ChecksumManager.instance(). Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-230) Race in ChecksumManager.instance()
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-230:
----------------------------------------
Assignee: Jonathan Ellis
> Race in ChecksumManager.instance()
> ----------------------------------
>
> Key: CASSANDRA-230
> URL: https://issues.apache.org/jira/browse/CASSANDRA-230
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Stu Hood
> Assignee: Jonathan Ellis
> Attachments: 230.patch, checksum-manager-race.patch
>
>
> There is a minor race condition in ChecksumManager.instance(). Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-230) Race in
ChecksumManager.instance()
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719614#action_12719614 ]
Stu Hood commented on CASSANDRA-230:
------------------------------------
Agreed. I didn't realize that code was unused.
> Race in ChecksumManager.instance()
> ----------------------------------
>
> Key: CASSANDRA-230
> URL: https://issues.apache.org/jira/browse/CASSANDRA-230
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Stu Hood
> Assignee: Jonathan Ellis
> Attachments: 230.patch, checksum-manager-race.patch
>
>
> There is a minor race condition in ChecksumManager.instance(). Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-230) Race in ChecksumManager.instance()
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-230:
-------------------------------------
Component/s: Core
> Race in ChecksumManager.instance()
> ----------------------------------
>
> Key: CASSANDRA-230
> URL: https://issues.apache.org/jira/browse/CASSANDRA-230
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Stu Hood
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 230.patch, checksum-manager-race.patch
>
>
> There is a minor race condition in ChecksumManager.instance(). Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-230) Race in
ChecksumManager.instance()
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719579#action_12719579 ]
Jonathan Ellis commented on CASSANDRA-230:
------------------------------------------
I think removing ChecksumManager and ChecksumRandomAccessFile is a better fix, because
1. they are unused
2. CRAF is a copy/paste modification of BufferedRAF
3. checksum-per-block is the wrong approach; we want checksum-per-column (and per-CF-index) instead so we can checksum reads easily
> Race in ChecksumManager.instance()
> ----------------------------------
>
> Key: CASSANDRA-230
> URL: https://issues.apache.org/jira/browse/CASSANDRA-230
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Stu Hood
> Attachments: 230.patch, checksum-manager-race.patch
>
>
> There is a minor race condition in ChecksumManager.instance(). Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-230) Race in
ChecksumManager.instance()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720101#action_12720101 ]
Hudson commented on CASSANDRA-230:
----------------------------------
Integrated in Cassandra #110 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/110/])
r/m CM and CRAF. patch by jbellis; reviewed by Stu Hood for
> Race in ChecksumManager.instance()
> ----------------------------------
>
> Key: CASSANDRA-230
> URL: https://issues.apache.org/jira/browse/CASSANDRA-230
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Stu Hood
> Assignee: Jonathan Ellis
> Attachments: 230.patch, checksum-manager-race.patch
>
>
> There is a minor race condition in ChecksumManager.instance(). Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-230) Race in ChecksumManager.instance()
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-230:
-------------------------------
Attachment: checksum-manager-race.patch
> Race in ChecksumManager.instance()
> ----------------------------------
>
> Key: CASSANDRA-230
> URL: https://issues.apache.org/jira/browse/CASSANDRA-230
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Stu Hood
> Attachments: checksum-manager-race.patch
>
>
> There is a minor race condition in ChecksumManager.instance(). Patch attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.