[GitHub] [cordova-android] dpogue commented on a change in pull request #699: Improve Gradle Build Arguments

[GitBox <gi...@apache.org>]

dpogue commented on a change in pull request #699: Improve Gradle Build Arguments
URL: https://github.com/apache/cordova-android/pull/699#discussion_r270243707
 
 

 ##########
 File path: bin/templates/cordova/lib/build.js
 ##########
 @@ -266,6 +270,8 @@ module.exports.help = function () {
     console.log('    \'--prepenv\': don\'t build, but copy in build scripts where necessary');
     console.log('    \'--versionCode=#\': Override versionCode for this build. Useful for uploading multiple APKs.');
     console.log('    \'--minSdkVersion=#\': Override minSdkVersion for this build. Useful for uploading multiple APKs.');
+    console.log('    \'--maxSdkVersion=#\': Override maxSdkVersion for this build. Useful for uploading multiple APKs.');
 
 Review comment:
   Remove "Useful for uploading multiple APKs." from `minSdkVersion`, `maxSdkVersion`,  and`targetSdkVersion`.
   
   There's also probably no value in supporting `maxSdkVersion` since they really *really* strongly discourage using it (your app will not be compatible with newer versions of Android)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org