[GitHub] conglei commented on a change in pull request #6423: [SIP-5] Build metrics in query_object in the client

[GitBox <gi...@apache.org>]

conglei commented on a change in pull request #6423: [SIP-5] Build metrics in query_object in the client
URL: https://github.com/apache/incubator-superset/pull/6423#discussion_r236868345
 
 

 ##########
 File path: superset/common/query_object.py
 ##########
 @@ -17,9 +17,9 @@ class QueryObject:
     def __init__(
             self,
             granularity: str,
-            groupby: List[str],
-            metrics: List[Metric],
-            filters: List[str],
+            groupby: List[str] = None,
 
 Review comment:
   In python, setting the default value as `[]` violates lint rules, and this is recommended way to do so. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org